Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Align arrow version to system if arrow installed #162

Merged
merged 3 commits into from
May 17, 2023

Conversation

acezen
Copy link
Contributor

@acezen acezen commented May 17, 2023

Signed-off-by: acezen qiaozi.zwb@alibaba-inc.com

Committed-by: acezen from Dev container

Proposed changes

Address issue #161

Types of changes

What types of changes does your code introduce to GraphAr?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Fixed #161

Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>

Committed-by: acezen from Dev container
@github-actions
Copy link

github-actions bot commented May 17, 2023

🎊 PR Preview 5dc5c1a has been successfully built and deployed to https://alibaba-graphar-build-pr-162.surge.sh

🤖 By surge-preview

@acezen acezen requested review from sighingnow and lixueclaire May 17, 2023 06:17
@acezen acezen changed the title [C++] Align arrow version with system if arrow installed [C++] Align arrow version to system if arrow installed May 17, 2023
acezen added 2 commits May 17, 2023 06:21
Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>

Committed-by: acezen from Dev container
Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>

Committed-by: acezen from Dev container
Copy link
Contributor

@lixueclaire lixueclaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acezen acezen merged commit 1bc4656 into apache:main May 17, 2023
@acezen acezen deleted the 161-align-arrow-version branch May 17, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[C++][Improvement] Depends on and builds the same version of arrow if the arrow has been installed in system
3 participants