Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Support setting gradle property skipDockerTests by environment variant #4181

Closed
yuqi1129 opened this issue Jul 17, 2024 · 2 comments · Fixed by #4229
Closed
Assignees
Labels
0.6.0 Release v0.6.0 improvement Improvements on everything

Comments

@yuqi1129
Copy link
Contributor

yuqi1129 commented Jul 17, 2024

What would you like to be improved?

Currently, the value of skipDockerTests is true, which means, all docker related tests will not be ran by default if we execute gradle test, If we want to run a test that was marked the Tag annotation in IDE, then the following error will occur
image

and we need to modify the runtime configuration, such as adding -PskipDockerTest=false or change the value skipDockerTest to false in gradle.properties every time, it's rather tedious

I suggest we set the value by environment variant, so we can avoid changing skipDockerTest every time.

How should we improve?

No response

@yuqi1129 yuqi1129 added the improvement Improvements on everything label Jul 17, 2024
@FANNG1
Copy link
Contributor

FANNG1 commented Jul 18, 2024

+1

@featherchen
Copy link
Member

featherchen commented Jul 21, 2024

As the discussion in slack, we keep both gradle.properties and enviroment variable to control the tests, and the priority of the former should be higher.

@mchades mchades added the 0.6.0 Release v0.6.0 label Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.6.0 Release v0.6.0 improvement Improvements on everything
Projects
None yet
4 participants