Skip to content

Commit 0cb1061

Browse files
committed
HADOOP-19696. PR Feedback
The hadoop-cloud-storage-dist module is now only executed when the dist profile is set.
1 parent 4c10b3e commit 0cb1061

File tree

2 files changed

+18
-7
lines changed

2 files changed

+18
-7
lines changed

BUILDING.txt

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -391,7 +391,7 @@ Note that the site needs to be built in a second pass after other artifacts.
391391
----------------------------------------------------------------------------------
392392
Including Cloud Connector Dependencies in Distributions:
393393

394-
Hadoop distributions include the hadoop modules need to work with data and services
394+
Hadoop distributions include the hadoop modules needed to work with data and services
395395
on cloud infrastructure
396396

397397
However, dependencies are omitted for all cloud connectors except hadoop-azure
@@ -400,15 +400,14 @@ For the latter two modules, it depends on shading options.
400400

401401
For hadoop-aws the AWS SDK bundle.jar is omitted, but everything else is included.
402402

403-
404403
Excluding the extra binaries:
405-
* Keeps release artifact size below the limit of the ASF distribution network
404+
* Keeps release artifact size below the limit of the ASF distribution network.
406405
* Reduces download and size overhead in docker usage.
407-
* Reduces the CVE attack surface
406+
* Reduces the CVE attack surface and audit-related complaints about those same ScVES.
408407
* Reduces the risk of classpath conflict.
409408

410409
To produce a build with the specific desired dependencies, the build must be executed
411-
with the relevant profile of ${module}-package.
410+
with the relevant profile of ${module}-package alongside the -Pdist profile.
412411

413412
For example, a build with the hadoop-aws and hadoop-azure-datalake dependencies,
414413
run with

hadoop-cloud-storage-project/pom.xml

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@
3434
<module>hadoop-cos</module>
3535
<module>hadoop-huaweicloud</module>
3636
<module>hadoop-tos</module>
37-
<module>hadoop-cloud-storage-dist</module>
3837
</modules>
3938

4039
<build>
@@ -53,5 +52,18 @@
5352
</plugin>
5453
</plugins>
5554
</build>
56-
55+
<profiles>
56+
<profile>
57+
<id>dist</id>
58+
<activation>
59+
<activeByDefault>false</activeByDefault>
60+
<property>
61+
<name>tar</name>
62+
</property>
63+
</activation>
64+
<modules>
65+
<module>hadoop-cloud-storage-dist</module>
66+
</modules>
67+
</profile>
68+
</profiles>
5769
</project>

0 commit comments

Comments
 (0)