Skip to content

Commit 239cf0f

Browse files
committed
address Copilot review comments
1 parent 69fa1c7 commit 239cf0f

File tree

1 file changed

+5
-2
lines changed
  • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util

1 file changed

+5
-2
lines changed

hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/SignalUtil.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ public static class Signal {
6363
private static final DynMethods.UnboundMethod GET_NAME_UNBOUND_METHOD =
6464
new DynMethods.Builder("getName").impl(JDK_SIGNAL_CLAZZ).build();
6565

66-
private final Object/* sun.misc.SignalHandler */ delegate;
66+
private final Object/* sun.misc.Signal */ delegate;
6767
private final DynMethods.BoundMethod getNumberMethod;
6868
private final DynMethods.BoundMethod getNameMethod;
6969

@@ -91,6 +91,7 @@ public String getName() {
9191
return getNameMethod.invoke();
9292
}
9393

94+
@Override
9495
public boolean equals(Object obj) {
9596
if (this == obj) {
9697
return true;
@@ -101,10 +102,12 @@ public boolean equals(Object obj) {
101102
return false;
102103
}
103104

105+
@Override
104106
public int hashCode() {
105107
return delegate.hashCode();
106108
}
107109

110+
@Override
108111
public String toString() {
109112
return delegate.toString();
110113
}
@@ -117,7 +120,7 @@ public interface Handler {
117120

118121
static class JdkSignalHandlerImpl implements Handler {
119122

120-
private final Object/* sun.misc.Signal */ delegate;
123+
private final Object/* sun.misc.SignalHandler */ delegate;
121124
private final DynMethods.BoundMethod jdkSignalHandlerHandleMethod;
122125

123126
JdkSignalHandlerImpl(Handler handler) {

0 commit comments

Comments
 (0)