Skip to content

Commit 3d579ae

Browse files
committed
fix failed UTs
1 parent c723265 commit 3d579ae

File tree

2 files changed

+15
-4
lines changed

2 files changed

+15
-4
lines changed

hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@
6868
import org.apache.hadoop.hdfs.server.datanode.FinalizedReplica;
6969
import org.apache.hadoop.hdfs.server.datanode.ReplicaHandler;
7070
import org.apache.hadoop.hdfs.server.datanode.ReplicaInfo;
71+
import org.apache.hadoop.hdfs.server.datanode.ReplicaNotFoundException;
7172
import org.apache.hadoop.hdfs.server.datanode.ShortCircuitRegistry;
7273
import org.apache.hadoop.hdfs.server.datanode.StorageLocation;
7374
import org.apache.hadoop.hdfs.server.datanode.fsdataset.DataNodeVolumeMetrics;
@@ -1946,7 +1947,12 @@ public void delayDeleteReplica() {
19461947
assertFalse(uuids.contains(dn.getDatanodeUuid()));
19471948

19481949
// This replica has deleted from datanode memory.
1949-
assertNull(ds.getStoredBlock(bpid, extendedBlock.getBlockId()));
1950+
try {
1951+
Block storedBlock = ds.getStoredBlock(bpid, extendedBlock.getBlockId());
1952+
assertNull(storedBlock);
1953+
} catch (Exception e) {
1954+
GenericTestUtils.assertExceptionContains("ReplicaNotFoundException", e);
1955+
}
19501956
} finally {
19511957
cluster.shutdown();
19521958
DataNodeFaultInjector.set(oldInjector);

hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestDNFencing.java

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@
5050
import org.apache.hadoop.hdfs.server.datanode.DataNode;
5151
import org.apache.hadoop.hdfs.server.datanode.DataNodeTestUtils;
5252
import org.apache.hadoop.hdfs.server.datanode.InternalDataNodeTestUtils;
53+
import org.apache.hadoop.hdfs.server.datanode.ReplicaNotFoundException;
5354
import org.apache.hadoop.hdfs.server.namenode.NameNode;
5455
import org.apache.hadoop.hdfs.server.namenode.NameNodeAdapter;
5556
import org.apache.hadoop.io.IOUtils;
@@ -596,9 +597,13 @@ private int getTrueReplication(MiniDFSCluster cluster, ExtendedBlock block)
596597
throws IOException {
597598
int count = 0;
598599
for (DataNode dn : cluster.getDataNodes()) {
599-
if (DataNodeTestUtils.getFSDataset(dn).getStoredBlock(
600-
block.getBlockPoolId(), block.getBlockId()) != null) {
601-
count++;
600+
try {
601+
if (DataNodeTestUtils.getFSDataset(dn).getStoredBlock(
602+
block.getBlockPoolId(), block.getBlockId()) != null) {
603+
count++;
604+
}
605+
} catch (ReplicaNotFoundException e) {
606+
continue;
602607
}
603608
}
604609
return count;

0 commit comments

Comments
 (0)