HADOOP-19501 Skip tests that depend on SecurityManager if the JVM does not support it

Author: stoty

hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java

@@ -85,6 +85,7 @@
 import static org.hamcrest.CoreMatchers.is;
 import static org.hamcrest.CoreMatchers.not;
 import static org.junit.Assert.*;
+import static org.junit.Assume.assumeTrue;
 import static org.hamcrest.core.StringContains.containsString;
 
 /**
@@ -576,26 +577,32 @@ public void run() {
     //use SecurityManager to pause the copying of f1 and begin copying f2
     SecurityManager sm = System.getSecurityManager();
     System.out.println("SecurityManager = " + sm);
-    System.setSecurityManager(new SecurityManager() {
-      private boolean firstTime = true;
+    try {
+      System.setSecurityManager(new SecurityManager() {
+        private boolean firstTime = true;
 
-      @Override
-      public void checkPermission(Permission perm) {
-        if (firstTime) {
-          Thread t = Thread.currentThread();
-          if (!t.toString().contains("DataNode")) {
-            String s = "" + Arrays.asList(t.getStackTrace());
-            if (s.contains("FileUtil.copyContent")) {
-              //pause at FileUtil.copyContent
-
-              firstTime = false;
-              copy2ndFileThread.start();
-              try {Thread.sleep(5000);} catch (InterruptedException e) {}
+        @Override
+        public void checkPermission(Permission perm) {
+          if (firstTime) {
+            Thread t = Thread.currentThread();
+            if (!t.toString().contains("DataNode")) {
+              String s = "" + Arrays.asList(t.getStackTrace());
+              if (s.contains("FileUtil.copyContent")) {
+                //pause at FileUtil.copyContent
+
+                firstTime = false;
+                copy2ndFileThread.start();
+                try {Thread.sleep(5000);} catch (InterruptedException e) {}
+              }
             }
           }
         }
-      }
-    });
+      });
+    } catch (UnsupportedOperationException e) {
+      // Test is skipped because SecurityManager cannot be set (JEP411)
+      // TODO add message when migrating to Junit 5
+      assumeTrue(false);
+    }
     show("copy local " + f1 + " to remote " + dst);
     dfs.copyFromLocalFile(false, false, new Path(f1.getPath()), dst);
     show("done");

hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDatanodeRegistration.java

@@ -48,6 +48,7 @@
 import java.util.concurrent.TimeoutException;
 
 import static org.junit.Assert.*;
+import static org.junit.Assume.assumeTrue;
 import static org.mockito.Mockito.doReturn;
 import static org.mockito.Mockito.mock;
 
@@ -79,7 +80,13 @@ public void checkConnect(String host, int port) {
   @Test
   public void testDNSLookups() throws Exception {
     MonitorDNS sm = new MonitorDNS();
-    System.setSecurityManager(sm);
+    try {
+      System.setSecurityManager(sm);
+    } catch (UnsupportedOperationException e) {
+      // Test is skipped because SecurityManager cannot be set (JEP411)
+      // TODO add message when migrating to Junit 5
+      assumeTrue(false);
+    }
 
     MiniDFSCluster cluster = null;
     try {

hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/pipes/TestPipeApplication.java

@@ -272,8 +272,6 @@ public void testSubmitter() throws Exception {
     Submitter.setJavaPartitioner(conf, partitioner.getClass());
 
     assertEquals(PipesPartitioner.class, (Submitter.getJavaPartitioner(conf)));
-    // test going to call main method with System.exit(). Change Security
-    SecurityManager securityManager = System.getSecurityManager();
     // store System.out
     PrintStream oldps = System.out;
     ByteArrayOutputStream out = new ByteArrayOutputStream();
@@ -330,8 +328,6 @@ public void testSubmitter() throws Exception {
               + "archives to be unarchived on the compute machines"));
     } finally {
       System.setOut(oldps);
-      // restore
-      System.setSecurityManager(securityManager);
       if (psw != null) {
         // remove password files
         for (File file : psw) {
@@ -381,7 +377,6 @@ public void testSubmitter() throws Exception {
 
     } finally {
       System.setOut(oldps);
-      System.setSecurityManager(securityManager);
     }
 
   }

hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/TestExternalCall.java

@@ -38,6 +38,7 @@
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 import static org.junit.jupiter.api.Assertions.fail;
+import static org.junit.jupiter.api.Assumptions.assumeTrue;
 import static org.mockito.Mockito.any;
 import static org.mockito.Mockito.anyBoolean;
 import static org.mockito.Mockito.doReturn;
@@ -66,7 +67,12 @@ private static Configuration getConf() {
   public void setup() {
 
     securityManager = System.getSecurityManager();
-    System.setSecurityManager(new NoExitSecurityManager());
+    try {
+      System.setSecurityManager(new NoExitSecurityManager());
+    } catch (UnsupportedOperationException e) {
+      assumeTrue(false,
+          "Test is skipped because SecurityManager cannot be set (JEP411)");
+    }
     try {
       fs = FileSystem.get(getConf());
       root = new Path("target/tmp").makeQualified(fs.getUri(),

hadoop-tools/hadoop-gridmix/src/test/java/org/apache/hadoop/mapred/gridmix/TestGridmixSubmission.java

@@ -174,8 +174,6 @@ public void testStressSubmit() throws Exception {
   @Test (timeout=100000)
   public void testMain() throws Exception {
 
-    SecurityManager securityManager = System.getSecurityManager();
-
     final ByteArrayOutputStream bytes = new ByteArrayOutputStream();
     final PrintStream out = new PrintStream(bytes);
     final PrintStream oldOut = System.out;
@@ -190,7 +188,6 @@ public void testMain() throws Exception {
       ExitUtil.resetFirstExitException();
     } finally {
       System.setErr(oldOut);
-      System.setSecurityManager(securityManager);
     }
     String print = bytes.toString();
     // should be printed tip in std error stream

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/resources/TestCGroupsHandlerImpl.java

@@ -46,6 +46,7 @@
 import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 import static org.junit.jupiter.api.Assertions.fail;
+import static org.junit.jupiter.api.Assumptions.assumeTrue;
 import static org.mockito.ArgumentMatchers.eq;
 import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.verifyNoMoreInteractions;
@@ -371,7 +372,12 @@ private void testPreMountedControllerInitialization(String myHierarchy)
       assertFalse(cpuCgroupMountDir.delete(), "Could not delete cgroups");
       assertFalse(cpuCgroupMountDir.exists(), "Directory should be deleted");
       SecurityManager manager = System.getSecurityManager();
-      System.setSecurityManager(new MockSecurityManagerDenyWrite());
+      try {
+        System.setSecurityManager(new MockSecurityManagerDenyWrite());
+      } catch (UnsupportedOperationException e) {
+        assumeTrue(false,
+            "Test is skipped because SecurityManager cannot be set (JEP411)");
+      }
       try {
         cGroupsHandler.initializeCGroupController(
             CGroupsHandler.CGroupController.CPU);

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestCapacitySchedulerAsyncScheduling.java

@@ -66,6 +66,7 @@
 import org.apache.hadoop.yarn.server.scheduler.SchedulerRequestKey;
 import org.apache.hadoop.yarn.util.resource.Resources;
 import org.junit.Assert;
+import org.junit.Assume;
 import org.junit.Before;
 import org.junit.Test;
 import org.junit.contrib.java.lang.system.internal.NoExitSecurityManager;
@@ -1090,7 +1091,13 @@ public void testAsyncScheduleThreadExit() throws Exception {
     SecurityManager originalSecurityManager = System.getSecurityManager();
     NoExitSecurityManager noExitSecurityManager =
         new NoExitSecurityManager(originalSecurityManager);
-    System.setSecurityManager(noExitSecurityManager);
+    try {
+      System.setSecurityManager(noExitSecurityManager);
+    } catch (UnsupportedOperationException e) {
+      // Test is skipped because SecurityManager cannot be set (JEP411)
+      // TODO add message when migrating to Junit 5
+      Assume.assumeTrue(false);
+    }
 
     // test async-scheduling thread exit
     try{