Skip to content

Commit 87f268c

Browse files
committed
add Unit tests.
1 parent ebc8277 commit 87f268c

File tree

4 files changed

+28
-0
lines changed

4 files changed

+28
-0
lines changed

hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -280,6 +280,15 @@ public ActiveNamenodeResolver getNamenodeResolver() {
280280
return this.namenodeResolver;
281281
}
282282

283+
/**
284+
* Get the executor service used by invoking concurrent calls.
285+
* @return
286+
*/
287+
@VisibleForTesting
288+
public ThreadPoolExecutor getExecutorService() {
289+
return executorService;
290+
}
291+
283292
/**
284293
* Shutdown the client.
285294
*/

hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterRpc.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2426,4 +2426,9 @@ public void testCallerContextNotResetByAsyncHandler() throws IOException {
24262426
// The audit log should not contain async:true.
24272427
assertFalse(auditLog.getOutput().contains("async:true"));
24282428
}
2429+
2430+
@Test
2431+
public void testConcurrentCallExecutorInitial() {
2432+
assertNotNull(router.getRouterRpcClient().getExecutorService());
2433+
}
24292434
}

hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/async/TestRouterAsyncRpc.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
import static org.apache.hadoop.hdfs.server.federation.router.RBFConfigKeys.DFS_ROUTER_FAIRNESS_POLICY_CONTROLLER_CLASS;
3737
import static org.apache.hadoop.hdfs.server.federation.router.async.utils.AsyncUtil.syncReturn;
3838
import static org.junit.jupiter.api.Assertions.assertArrayEquals;
39+
import static org.junit.jupiter.api.Assertions.assertNull;
3940

4041
/**
4142
* Testing the asynchronous RPC functionality of the router.
@@ -83,4 +84,9 @@ public void testgetGroupsForUser() throws Exception {
8384
assertArrayEquals(group, result);
8485
}
8586

87+
@Test
88+
@Override
89+
public void testConcurrentCallExecutorInitial() {
90+
assertNull(rndRouter.getRouterRpcClient().getExecutorService());
91+
}
8692
}

hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/async/TestRouterAsyncRpcMultiDestination.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
import static org.apache.hadoop.hdfs.server.federation.router.RBFConfigKeys.DFS_ROUTER_FAIRNESS_POLICY_CONTROLLER_CLASS;
3535
import static org.apache.hadoop.hdfs.server.federation.router.async.utils.AsyncUtil.syncReturn;
3636
import static org.junit.jupiter.api.Assertions.assertArrayEquals;
37+
import static org.junit.jupiter.api.Assertions.assertNull;
3738

3839
/**
3940
* Testing the asynchronous RPC functionality of the router with multiple mounts.
@@ -70,4 +71,11 @@ public void testgetGroupsForUser() throws Exception {
7071
String[] result = syncReturn(String[].class);
7172
assertArrayEquals(group, result);
7273
}
74+
75+
@Test
76+
@Override
77+
public void testConcurrentCallExecutorInitial() {
78+
MiniRouterDFSCluster.RouterContext rndRouter = super.getRouterContext();
79+
assertNull(rndRouter.getRouterRpcClient().getExecutorService());
80+
}
7381
}

0 commit comments

Comments
 (0)