Skip to content

Commit 983f54d

Browse files
committed
HDFS-17705. Improve datasetlock related log output.
1 parent d7a462f commit 983f54d

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataSetLockManager.java

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ public AutoCloseDataSetLock readLock(LockLevel level, String... resources) {
179179
AutoCloseDataSetLock dirLock = getReadLock(level, resources);
180180
dirLock.setParentLock(volLock);
181181
if (openLockTrace) {
182-
LOG.debug("Sub lock " + resources[0] + resources[1] + resources[2] + " parent lock " +
182+
LOG.info("Sub lock " + resources[0] + resources[1] + resources[2] + " parent lock " +
183183
resources[0] + resources[1]);
184184
}
185185
return dirLock;
@@ -206,7 +206,7 @@ public AutoCloseDataSetLock writeLock(LockLevel level, String... resources) {
206206
AutoCloseDataSetLock dirLock = getWriteLock(level, resources);
207207
dirLock.setParentLock(volLock);
208208
if (openLockTrace) {
209-
LOG.debug("Sub lock " + resources[0] + resources[1] + resources[2] + " parent lock " +
209+
LOG.info("Sub lock " + resources[0] + resources[1] + resources[2] + " parent lock " +
210210
resources[0] + resources[1]);
211211
}
212212
return dirLock;
@@ -273,6 +273,9 @@ public void addLock(LockLevel level, String... resources) {
273273
new ReentrantReadWriteLock(isFair));
274274
lockMap.addLock(lockName, new ReentrantReadWriteLock(isFair));
275275
}
276+
if (openLockTrace) {
277+
LOG.info("Added {} lock, lock name: {}", level.name(), lockName);
278+
}
276279
}
277280

278281
@Override
@@ -281,6 +284,9 @@ public void removeLock(LockLevel level, String... resources) {
281284
try (AutoCloseDataSetLock lock = writeLock(level, resources)) {
282285
lockMap.removeLock(lockName);
283286
}
287+
if (openLockTrace) {
288+
LOG.info("Removed {} lock, lock name: {}", level.name(), lockName);
289+
}
284290
}
285291

286292
@Override

hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -439,9 +439,8 @@ private synchronized void activateVolume(
439439
List<String> allSubDirNameForDataSetLock = datasetSubLockStrategy.getAllSubLockNames();
440440
for (String dir : allSubDirNameForDataSetLock) {
441441
lockManager.addLock(LockLevel.DIR, bp, ref.getVolume().getStorageID(), dir);
442-
LOG.info("Added DIR lock for bpid:{}, volume storageid:{}, dir:{}",
443-
bp, ref.getVolume().getStorageID(), dir);
444442
}
443+
LOG.info("Added DIR lock for bpid:{}, volume storageid:{}.", bp, ref.getVolume().getStorageID());
445444
}
446445
DatanodeStorage dnStorage = storageMap.get(sd.getStorageUuid());
447446
if (dnStorage != null) {
@@ -3297,9 +3296,8 @@ public void addBlockPool(String bpid, Configuration conf)
32973296
List<String> allSubDirNameForDataSetLock = datasetSubLockStrategy.getAllSubLockNames();
32983297
for (String dir : allSubDirNameForDataSetLock) {
32993298
lockManager.addLock(LockLevel.DIR, bpid, v, dir);
3300-
LOG.info("Added DIR lock for bpid:{}, volume storageid:{}, dir:{}",
3301-
bpid, v, dir);
33023299
}
3300+
LOG.info("Added DIR lock for bpid:{}, volume storageid:{}.", bpid, v);
33033301
}
33043302
}
33053303
try {

0 commit comments

Comments
 (0)