Skip to content

Commit c236d34

Browse files
tomscutsunchao
authored andcommitted
HDFS-16326. Simplify the code for DiskBalancer (#3663)
Reviewed-by: Viraj Jasani <vjasani@apache.org> (cherry picked from commit 965e387)
1 parent 1e7a46b commit c236d34

File tree

1 file changed

+2
-2
lines changed
  • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode

1 file changed

+2
-2
lines changed

hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DiskBalancer.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -808,7 +808,7 @@ private boolean isLessThanNeeded(long blockSize,
808808
long bytesToCopy = item.getBytesToCopy() - item.getBytesCopied();
809809
bytesToCopy = bytesToCopy +
810810
((bytesToCopy * getBlockTolerancePercentage(item)) / 100);
811-
return (blockSize <= bytesToCopy) ? true : false;
811+
return blockSize <= bytesToCopy;
812812
}
813813

814814
/**
@@ -833,7 +833,7 @@ private long getBlockTolerancePercentage(DiskBalancerWorkItem item) {
833833
private boolean isCloseEnough(DiskBalancerWorkItem item) {
834834
long temp = item.getBytesCopied() +
835835
((item.getBytesCopied() * getBlockTolerancePercentage(item)) / 100);
836-
return (item.getBytesToCopy() >= temp) ? false : true;
836+
return item.getBytesToCopy() < temp;
837837
}
838838

839839
/**

0 commit comments

Comments
 (0)