Skip to content

Commit c92ff0b

Browse files
authored
HADOOP-18372. ILoadTestS3ABulkDeleteThrottling failing. (#4642)
Contributed by Ahmar Suhail
1 parent 4c8cd61 commit c92ff0b

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/scale/ILoadTestS3ABulkDeleteThrottling.java

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@
4545
import org.apache.hadoop.conf.Configuration;
4646
import org.apache.hadoop.fs.Path;
4747
import org.apache.hadoop.fs.contract.ContractTestUtils;
48+
import org.apache.hadoop.fs.store.audit.AuditSpan;
4849
import org.apache.hadoop.fs.s3a.S3AFileSystem;
4950
import org.apache.hadoop.fs.s3a.S3ATestUtils;
5051
import org.apache.hadoop.fs.s3a.auth.delegation.Csvout;
@@ -144,26 +145,25 @@ public ILoadTestS3ABulkDeleteThrottling(
144145
@Override
145146
protected Configuration createScaleConfiguration() {
146147
Configuration conf = super.createScaleConfiguration();
147-
S3ATestUtils.disableFilesystemCaching(conf);
148-
return conf;
149-
}
150148

151-
@Override
152-
public void setup() throws Exception {
153-
final Configuration conf = getConf();
154149
S3ATestUtils.removeBaseAndBucketOverrides(conf,
155150
EXPERIMENTAL_AWS_INTERNAL_THROTTLING,
156151
BULK_DELETE_PAGE_SIZE,
157-
USER_AGENT_PREFIX);
152+
USER_AGENT_PREFIX,
153+
ENABLE_MULTI_DELETE);
158154
conf.setBoolean(EXPERIMENTAL_AWS_INTERNAL_THROTTLING, throttle);
159-
Assertions.assertThat(pageSize)
160-
.describedAs("page size")
161-
.isGreaterThan(0);
162155
conf.setInt(BULK_DELETE_PAGE_SIZE, pageSize);
163156
conf.set(USER_AGENT_PREFIX,
164157
String.format("ILoadTestS3ABulkDeleteThrottling-%s-%04d",
165158
throttle, pageSize));
166159

160+
S3ATestUtils.disableFilesystemCaching(conf);
161+
return conf;
162+
}
163+
164+
@Override
165+
public void setup() throws Exception {
166+
final Configuration conf = getConf();
167167
super.setup();
168168
Assume.assumeTrue("multipart delete disabled",
169169
conf.getBoolean(ENABLE_MULTI_DELETE, true));
@@ -246,7 +246,7 @@ private File deleteFiles(final int requestCount,
246246
final ContractTestUtils.NanoTimer timer =
247247
new ContractTestUtils.NanoTimer();
248248
Exception ex = null;
249-
try {
249+
try (AuditSpan span = span()) {
250250
fs.removeKeys(fileList, false);
251251
} catch (IOException e) {
252252
ex = e;

0 commit comments

Comments
 (0)