YARN-11879. Fix SpotBugs issues in hadoop-yarn-common module.

Author: slfan1989

hadoop-project/pom.xml

@@ -2161,6 +2161,11 @@
       <artifactId>google-cloud-storage</artifactId>
       <version>2.52.0</version>
     </dependency>
+    <dependency>
+      <groupId>com.github.spotbugs</groupId>
+      <artifactId>spotbugs-annotations</artifactId>
+      <version>{spotbugs.version}</version>
+    </dependency>
     </dependencies>
   </dependencyManagement>
 

hadoop-yarn-project/hadoop-yarn/dev-support/findbugs-exclude.xml

@@ -726,4 +726,10 @@
     <Package name="org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.placement.schema" />
   </Match>
 
+  <Match>
+    <Package name="org.apache.hadoop.yarn.api.records.impl.pb"/>
+    <Class name="~.*Impl$"/>
+    <Bug pattern="AT_STALE_THREAD_WRITE_OF_PRIMITIVE"/>
+  </Match>
+
 </FindBugsFilter>

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/pom.xml

@@ -213,6 +213,12 @@
       <artifactId>jettison</artifactId>
       <scope>compile</scope>
     </dependency>
+    <dependency>
+      <groupId>com.github.spotbugs</groupId>
+      <artifactId>spotbugs-annotations</artifactId>
+      <version>4.9.7</version>
+      <scope>provided</scope>
+    </dependency>
   </dependencies>
 
   <build>

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/ContainerLogAppender.java

@@ -38,7 +38,7 @@ public class ContainerLogAppender extends FileAppender
 
   private String containerLogDir;
   private String containerLogFile;
-  private int maxEvents;
+  private volatile int maxEvents;
   private Deque<LoggingEvent> eventBuffer;
   private boolean closed = false;
 

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/impl/pb/client/ApplicationClientProtocolPBClientImpl.java

@@ -22,6 +22,7 @@
 import java.io.IOException;
 import java.net.InetSocketAddress;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import org.apache.hadoop.classification.InterfaceAudience.Private;
 import org.apache.hadoop.conf.Configuration;
 import org.apache.hadoop.ipc.ProtobufRpcEngine2;
@@ -204,6 +205,9 @@ public class ApplicationClientProtocolPBClientImpl implements ApplicationClientP
 
   private ApplicationClientProtocolPB proxy;
 
+  @SuppressFBWarnings(
+      value = "CT_CONSTRUCTOR_THROW",
+      justification = "Expected checked exception during initialization; safe and intentional.")
   public ApplicationClientProtocolPBClientImpl(long clientVersion,
       InetSocketAddress addr, Configuration conf) throws IOException {
     RPC.setProtocolEngine(conf, ApplicationClientProtocolPB.class,

hadoop-yarn-project/pom.xml

@@ -292,6 +292,10 @@
         <artifactId>spotbugs-maven-plugin</artifactId>
         <configuration>
           <xmlOutput>true</xmlOutput>
+          <excludeFilterFile>
+             ${basedir}/dev-support/findbugs-exclude.xml
+          </excludeFilterFile>
+          <effort>Max</effort>
         </configuration>
       </plugin>
     </plugins>