Skip to content

Commit e2c02ef

Browse files
committed
HBASE-22724 Add a emoji on the vote table for pre commit result on github
1 parent 1ea5d8b commit e2c02ef

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

dev-support/Jenkinsfile_GitHub

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ pipeline {
3737
DOCKERFILE = "${SOURCEDIR}/dev-support/docker/Dockerfile"
3838
YETUS='yetus'
3939
// Branch or tag name. Yetus release tags are 'rel/X.Y.Z'
40-
YETUS_VERSION='rel/0.10.0'
40+
YETUS_VERSION='YETUS-899'
4141
}
4242

4343
parameters {
@@ -151,18 +151,17 @@ pipeline {
151151
YETUS_ARGS+=("--docker")
152152
YETUS_ARGS+=("--dockerfile=${DOCKERFILE}")
153153
YETUS_ARGS+=("--mvn-custom-repos")
154-
YETUS_ARGS+=("--jenkins")
155154
YETUS_ARGS+=("--multijdkdirs=/usr/lib/jvm/java-8-openjdk-amd64")
156155
YETUS_ARGS+=("--findbugs-home=/usr")
157156
YETUS_ARGS+=("--whitespace-eol-ignore-list=.*/generated/.*")
158157
YETUS_ARGS+=("--whitespace-tabs-ignore-list=.*/generated/.*")
159158
YETUS_ARGS+=("--personality=${SOURCEDIR}/dev-support/hbase-personality.sh")
160159
YETUS_ARGS+=("--quick-hadoopcheck")
161160
YETUS_ARGS+=("--skip-errorprone")
162-
# effectively treat dev-support as a custom maven module
163-
YETUS_ARGS+=("--skip-dir=dev-support")
164161
# help keep the ASF boxes clean
165162
YETUS_ARGS+=("--sentinel")
163+
# use emoji vote so it is easier to find the broken line
164+
YETUS_ARGS+=("--github-use-emoji-vote")
166165
"${TESTPATCHBIN}" "${YETUS_ARGS[@]}"
167166
'''
168167
}

dev-support/hbase-personality.sh

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,15 +86,19 @@ function personality_parse_args
8686
for i in "$@"; do
8787
case ${i} in
8888
--exclude-tests-url=*)
89+
delete_parameter "${i}"
8990
EXCLUDE_TESTS_URL=${i#*=}
9091
;;
9192
--include-tests-url=*)
93+
delete_parameter "${i}"
9294
INCLUDE_TESTS_URL=${i#*=}
9395
;;
9496
--hadoop-profile=*)
97+
delete_parameter "${i}"
9598
HADOOP_PROFILE=${i#*=}
9699
;;
97100
--skip-errorprone)
101+
delete_parameter "${i}"
98102
SKIP_ERRORPRONE=true
99103
;;
100104
esac
@@ -462,6 +466,7 @@ function hadoopcheck_parse_args
462466
for i in "$@"; do
463467
case ${i} in
464468
--quick-hadoopcheck)
469+
delete_parameter "${i}"
465470
QUICK_HADOOPCHECK=true
466471
;;
467472
esac

0 commit comments

Comments
 (0)