Skip to content

Commit e9ea54d

Browse files
authored
oracle bulk loader fixes #4322 (#4325)
* fix missing connection line. #4322 * fix NPE in SQL statements. #4322 * fix incorrect SQL Loader command. #4322 * oracle docker compose initial version. #4322 * removed oracle docker compose placeholder. #4322
1 parent 5aac881 commit e9ea54d

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

plugins/transforms/orabulkloader/src/main/java/org/apache/hop/pipeline/transforms/orabulkloader/OraBulkLoader.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -438,7 +438,7 @@ public String createCommandLine(OraBulkLoaderMeta meta, boolean password) throws
438438
databaseName = '"' + databaseName + '"';
439439
}
440440

441-
sb.append(databaseName);
441+
sb.append("/" + databaseName);
442442
} else {
443443
throw new HopException("No connection specified");
444444
}

plugins/transforms/orabulkloader/src/main/java/org/apache/hop/pipeline/transforms/orabulkloader/OraBulkLoaderDialog.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,8 @@ public void widgetSelected(SelectionEvent e) {
234234
};
235235

236236
// Connection line
237-
wConnection = addConnectionLine(shell, wTransformName, input.getConnection(), lsMod);
237+
wConnection =
238+
addConnectionLine(wBulkLoaderComposite, wTransformName, input.getConnection(), lsMod);
238239
wConnection.addSelectionListener(lsSelection);
239240

240241
// Schema line...

plugins/transforms/orabulkloader/src/main/java/org/apache/hop/pipeline/transforms/orabulkloader/OraBulkLoaderMeta.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -546,8 +546,7 @@ public SqlStatement getSqlStatements(
546546
IHopMetadataProvider metadataProvider)
547547
throws HopTransformException {
548548

549-
DatabaseMeta databaseMeta =
550-
getParentTransformMeta().getParentPipelineMeta().findDatabase(connection, variables);
549+
DatabaseMeta databaseMeta = pipelineMeta.findDatabase(connection, variables);
551550

552551
SqlStatement retval =
553552
new SqlStatement(transformMeta.getName(), databaseMeta, null); // default: nothing to do!

0 commit comments

Comments
 (0)