Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new a target make dev-setup to install dependencies #529

Closed
dust1 opened this issue Jan 3, 2023 · 3 comments · Fixed by #815
Closed

add new a target make dev-setup to install dependencies #529

dust1 opened this issue Jan 3, 2023 · 3 comments · Fixed by #815
Assignees
Labels
feature New feature or request good first issue Good for newcomers

Comments

@dust1
Copy link
Contributor

dust1 commented Jan 3, 2023

Describe This Problem

it just echo branch

Proposal

Initialize the environment or install the necessary tools, e.g. pkg-config, libssl-dev.

Additional Context

No response

@dust1 dust1 added the feature New feature or request label Jan 3, 2023
@jiacai2050
Copy link
Contributor

I think current usage is a convention, init is a common task(such as setting env vars) which others can depend on.

It should be light weighted, install dependencies is kinds of a heavy task, so it may not suit here.

@dust1
Copy link
Contributor Author

dust1 commented Jan 3, 2023

Whether ceresdb will have commands to install dependencies in the future? e.g. make setup.
I recently used ceresdb in a new environment and would it be much easier to have such a command

@jiacai2050
Copy link
Contributor

We can add new a target to install those dependencies. Example:

dev-setup:
  if macOS
    brew install protobuf
  if Ubuntu 
    sudo apt install --yes protobuf-compiler

@jiacai2050 jiacai2050 added the good first issue Good for newcomers label Jan 3, 2023
@dust1 dust1 changed the title the make init doesn't seem to do anything else add new a target make dev-setup to install those dependencies Jan 4, 2023
@dust1 dust1 changed the title add new a target make dev-setup to install those dependencies add new a target make dev-setup to install dependencies Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants