Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid dictionary (de)serialization for model modification #179

Closed
Fokko opened this issue Dec 4, 2023 · 0 comments · Fixed by #182
Closed

Avoid dictionary (de)serialization for model modification #179

Fokko opened this issue Dec 4, 2023 · 0 comments · Fixed by #182

Comments

@Fokko
Copy link
Contributor

Fokko commented Dec 4, 2023

Feature Request / Improvement

Based on a comment in #139 (comment)

Instead it is better to use Pydantic's model_copy this avoids pulling all the data to the Python, and will do the copy in Rust 🦀 . For users that use this in a loop, it is good to keep performance in mind.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Pydantic's model_copy for model modification when updating table metadata HonahX/iceberg-python
1 participant
@Fokko