Skip to content

Commit de57b76

Browse files
committed
make interface of merge append action consistent
1 parent 67918fb commit de57b76

File tree

2 files changed

+3
-9
lines changed

2 files changed

+3
-9
lines changed

crates/iceberg/src/transaction/merge_append.rs

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -106,12 +106,9 @@ impl MergeAppendAction {
106106
}
107107

108108
/// Add data files to the snapshot.
109-
pub fn add_data_files(
110-
&mut self,
111-
data_files: impl IntoIterator<Item = DataFile>,
112-
) -> Result<&mut Self> {
109+
pub fn add_data_files(mut self, data_files: impl IntoIterator<Item = DataFile>) -> Self {
113110
self.added_data_files.extend(data_files);
114-
Ok(self)
111+
self
115112
}
116113
}
117114

crates/integration_tests/tests/shared_tests/merge_append_test.rs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -173,10 +173,7 @@ async fn test_append_data_file() {
173173
// append data file with merge append, 4 data file will be merged to two manifest
174174
let data_file = write_new_data_file(&table).await;
175175
let tx = Transaction::new(&table);
176-
let mut merge_append_action = tx.merge_append().unwrap();
177-
merge_append_action
178-
.add_data_files(data_file.clone())
179-
.unwrap();
176+
let merge_append_action = tx.merge_append().unwrap().add_data_files(data_file.clone());
180177
let tx = merge_append_action.apply(tx).unwrap();
181178
table = tx.commit(&rest_catalog).await.unwrap();
182179
// Check manifest file

0 commit comments

Comments
 (0)