Skip to content

Commit f47a896

Browse files
authored
ci: only use -Z direct-minimal-versions for MSRV check (#1656)
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> - Closes #. ## What changes are included in this PR? <!-- Provide a summary of the modifications in this PR. List the main changes such as new features, bug fixes, refactoring, or any other updates. --> Context: #1195 (comment) [the docs](https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#minimal-versions) mentions that the feature is not recommended anymore I've ran an issue with this flag when upgrading datafusion from 47 -> 48. -Z minimal-versions will pull in very old versions of transitive dependencies ## Are these changes tested? <!-- Specify what test covers (unit test, integration test, etc.). If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? -->
1 parent 788d76e commit f47a896

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ jobs:
144144
uses: ./.github/actions/setup-builder
145145
- name: Generate minimal versions lockfile
146146
run: |
147-
cargo generate-lockfile -Z direct-minimal-versions -Z minimal-versions
147+
cargo generate-lockfile -Z direct-minimal-versions
148148
- name: Setup MSRV Rust toolchain
149149
uses: ./.github/actions/setup-builder
150150
with:

0 commit comments

Comments
 (0)