You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I believe it should be optional. The comment correctly states that: 'Defaults to table property history.expire.max-ref-age-ms'.
It can only default to something if its optional. In the Branch Variant it is optional.
Currently the field
max_ref_age_ms
of the Tag Variant ofSnapshotRetention
is required:iceberg-rust/crates/iceberg/src/spec/snapshot.rs
Line 354 in f1ea6e1
I believe it should be optional. The comment correctly states that: 'Defaults to table property history.expire.max-ref-age-ms'.
It can only default to something if its optional. In the
Branch
Variant it is optional.Unfortunately this would be a breaking change.
In pyiceberg, its optional:
https://github.com/apache/iceberg-python/blob/0155405d7da141efba60ba502f6c6c1cbc97bdf9/pyiceberg/table/refs.py#L47
The text was updated successfully, but these errors were encountered: