Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: SnapshotRetention::Tag max_ref_age_ms should be optional #392

Closed
c-thiel opened this issue Jun 7, 2024 · 1 comment
Closed

bug: SnapshotRetention::Tag max_ref_age_ms should be optional #392

c-thiel opened this issue Jun 7, 2024 · 1 comment

Comments

@c-thiel
Copy link
Collaborator

c-thiel commented Jun 7, 2024

Currently the field max_ref_age_ms of the Tag Variant of SnapshotRetention is required:

I believe it should be optional. The comment correctly states that: 'Defaults to table property history.expire.max-ref-age-ms'.
It can only default to something if its optional. In the Branch Variant it is optional.

Unfortunately this would be a breaking change.

In pyiceberg, its optional:
https://github.com/apache/iceberg-python/blob/0155405d7da141efba60ba502f6c6c1cbc97bdf9/pyiceberg/table/refs.py#L47

@liurenjie1024
Copy link
Contributor

Close by #391

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants