Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically load LocationProvider implementation #1538

Closed
jackye1995 opened this issue Oct 1, 2020 · 1 comment · Fixed by #1531
Closed

Dynamically load LocationProvider implementation #1538

jackye1995 opened this issue Oct 1, 2020 · 1 comment · Fixed by #1531

Comments

@jackye1995
Copy link
Contributor

Currently the LocationProviders class only load either DefaultLocationProvider which follows the Hive standard or the ObjectStoreLocationProvider that is optimized for cloud storage use case. Use cases like #1531 will become increasingly common, and we should allow users to load their custom location providers without the need to change core package.

Therefore, I propose dynamically loading the LocationProvider implementation in the method LocationProviders.locationsFor and use new table property write.location-provider.class to determine the class. Table property write.object-storage.enabled will still be supported to keep backwards compatibility.

Plan to submit a PR in 1-2 days, please let me know if there is any concern, thanks.

@mickjermsurawong-stripe
Copy link
Contributor

mickjermsurawong-stripe commented Oct 1, 2020

This PR #1531 was re-purposed from solving specific problem of data localization to address this more general use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants