Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iceberg-mr: Switch tests to JUnit5 + AssertJ-style assertions #9083

Closed
nastra opened this issue Nov 15, 2023 · 2 comments · Fixed by #9241
Closed

iceberg-mr: Switch tests to JUnit5 + AssertJ-style assertions #9083

nastra opened this issue Nov 15, 2023 · 2 comments · Fixed by #9241
Labels
beginner Issues for apache iceberg beginners, enjoy to contribute ! good first issue Good for newcomers

Comments

@nastra
Copy link
Contributor

nastra commented Nov 15, 2023

Feature Request / Improvement

The goal is to switch all imports to JUni5 imports and to use AssertJ-style assertions

Query engine

None
@nastra nastra added good first issue Good for newcomers beginner Issues for apache iceberg beginners, enjoy to contribute ! labels Nov 15, 2023
@lschetanrao
Copy link
Contributor

Hi @nastra, I am new to contributing in open source but I would like to try this if you don't mind.

@nastra
Copy link
Contributor Author

nastra commented Nov 27, 2023

@lschetanrao sure that would be great. Just go ahead and open a PR with the proper changes. You might want to look into git history of how other modules have been migrated to JUnit5 + AssertJ-style assertions

@lschetanrao lschetanrao mentioned this issue Dec 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner Issues for apache iceberg beginners, enjoy to contribute ! good first issue Good for newcomers
Projects
JUnit4 to JUnit5 Migration
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch to junit5 for mr lschetanrao/iceberg
2 participants
@nastra @lschetanrao