Modify bin/apisix to support the SO_REUSEPORT #1085

Miss-you · 2020-01-19T14:49:10Z

NOTE: Please read the Contributing.md guidelines before submitting your patch:

https://github.com/apache/incubator-apisix/blob/master/Contributing.md#how-to-add-a-new-feature-or-change-an-existing-one

Summary

Modify bin/apisix to increase the capacity so that the generated nginx.conf file can open the reuseport configuration
Judgment logic:
1. If it is a mac system, do not open reuseport
2. If it is a linux system and the kernel version is higher than 3.9.0, then turn on the reuserport switch, and the reuseport option will be added when generating nginx.conf> configuration

Full changelog

bin/apisix

Issues resolved

Fix #342

…generated nginx.conf file can open the reuseport configuration Judgment logic: 1. If it is a mac system, do not open reuseport 2. If it is a linux system and the kernel version is higher than 3.9.0, then turn on the reuserport switch, and the reuseport option will be added when generating nginx.conf> configuration

membphis · 2020-01-20T02:00:45Z

bin/apisix

+        {% end %}
+
+        {% else %} {% --if enable_reuseport %}
+
        {% for _, port in ipairs(stream_proxy.tcp or {}) do %}
        listen {*port*};


listen {*port*} {% if enable_reuseport then %} reuseport {% end %};

This style is simpler.

moonming

please add test cases.

Test cases to be added after pull request # 1063 apache#1063

Miss-you · 2020-01-22T05:00:00Z

@moonming Test cases will be added after pull request # 1063
#1063

membphis · 2020-01-22T08:20:08Z

@Miss-you #1063 had been merged already.

spacewander · 2020-01-24T14:45:49Z

Strictly speaking, detect if a feature is available or not via kernel version is not reliable. Linux distributions may backport kernel patch to an old release (search for "SO_REUSEPORT backport for linux distribution"), not even mentioning self-patched kernel.

I think a better solution is to allow the users to configure it, since they know better about their servers than us. Maybe we can enable this feature by default, because most of the servers have kernel newer than 3.9.

Miss-you · 2020-02-03T12:37:59Z

Considering that the kernel version of the current production environment basically supports reuseport, I think it is more reasonable to open the REUSEPORT configuration file by default and supporting configuration it.

Miss-you · 2020-02-03T12:38:59Z

I remember that there are two main pits in reuseport, one is the kernel version, and the other is the support of http2 and http3.

membphis · 2020-02-03T13:38:18Z

open the REUSEPORT configuration file by default and supporting configuration it.

this way is simpler. thx @spacewander

@Miss-you Expect your new commit ^_^

…uction environment basically supports reuseport, I think it is more reasonable to open the REUSEPORT configuration file by default and supporting configuration it. So, it's a better solution is to allow the users to configure the 'enable_reuseport'.

Miss-you · 2020-02-05T16:13:54Z

@membphis @spacewander
hi, I have add the 'enable_reuseport' config into config.yaml. Please take a look.

moonming · 2020-02-06T02:13:02Z

bin/apisix

@@ -507,6 +507,7 @@ local function init()
        with_module_status = with_module_status,
        node_ssl_listen = 9443,     -- default value
        error_log = {level = "warn"},
+        enable_reuseport = true, -- default true


the default value should be set in config.yaml, not here.

moonming · 2020-02-06T02:13:38Z

bin/apisix

+    if sys_conf["enable_reuseport"] == false then
+        enable_reuseport = false
+    end
+


we can use the enable_reuseport in config.yaml

…aml'

membphis · 2020-02-06T09:38:48Z

waiting your test case ^_^

update apache/incubator-apisix

membphis · 2020-02-06T12:34:58Z

conf/config.yaml

@@ -21,7 +21,7 @@ apisix:
  enable_admin_cors: true         # Admin API support CORS response headers.
  enable_debug: false
  enable_dev_mode: false          # Sets nginx worker_processes to 1 if set to true
-  enable_reuseport: true          # Enable nginx SO_REUSEPORT switch if set to true.
+  enable_reuseport: false          # Enable nginx SO_REUSEPORT switch if set to true.


default value true is better

setting enable_reuseport false to verify that test cases are working.

For testing, you can write a separate script to modify config.yaml.

…_runner.sh 1.fix issue 'can not find openresty' 2.remove function 'check_result' 3.fix .gitignore

membphis · 2020-02-08T09:07:58Z

https://travis-ci.org/apache/incubator-apisix/jobs/647645479#L1426

membphis · 2020-02-09T09:18:52Z

ok, we can merge it to master branch first for checking it can work fine.

Fix apache#342

membphis reviewed Jan 20, 2020

View reviewed changes

moonming reviewed Jan 20, 2020

View reviewed changes

yousali:<fix>:Improve code based on suggested changes

502830a

Test cases to be added after pull request # 1063 apache#1063

moonming reviewed Feb 6, 2020

View reviewed changes

yousali:<fix>set the default value of 'enable_reuseport' in 'config.y…

7dcdeb4

…aml'

Merge pull request #1 from apache/master

446cba4

update apache/incubator-apisix

membphis reviewed Feb 6, 2020

View reviewed changes

Miss-you force-pushed the master branch 2 times, most recently from 2b61386 to 56e1d97 Compare February 7, 2020 02:29

yousali:<fix>add test case to test 'nginx.conf'

d0193cd

Miss-you force-pushed the master branch 10 times, most recently from 5a7ec3d to 62dc89d Compare February 8, 2020 04:01

Miss-you force-pushed the master branch from 62dc89d to 299a4df Compare February 8, 2020 04:29

yousali:<fix>Fix issue with execution in script linux_apisix_luarocks…

b93c44c

…_runner.sh 1.fix issue 'can not find openresty' 2.remove function 'check_result' 3.fix .gitignore

Miss-you force-pushed the master branch from 299a4df to b93c44c Compare February 8, 2020 07:33

membphis approved these changes Feb 9, 2020

View reviewed changes

membphis merged commit 60b2493 into apache:master Feb 9, 2020

membphis mentioned this pull request Feb 9, 2020

CLI: added missing Lua path. #1114

Merged

SaberMaster pushed a commit to SaberMaster/incubator-apisix that referenced this pull request Jun 30, 2020

CLI: bin/apisix to support the SO_REUSEPORT (apache#1085)

c8ac99d

Fix apache#342

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Modify bin/apisix to support the SO_REUSEPORT #1085

Modify bin/apisix to support the SO_REUSEPORT #1085

Miss-you commented Jan 19, 2020

membphis Jan 20, 2020

moonming left a comment

Miss-you commented Jan 22, 2020 •

edited

Loading

membphis commented Jan 22, 2020

spacewander commented Jan 24, 2020

Miss-you commented Feb 3, 2020

Miss-you commented Feb 3, 2020

membphis commented Feb 3, 2020

Miss-you commented Feb 5, 2020

moonming Feb 6, 2020

Miss-you Feb 6, 2020

moonming Feb 6, 2020

Miss-you Feb 6, 2020

membphis commented Feb 6, 2020

membphis Feb 6, 2020

Miss-you Feb 6, 2020

membphis Feb 7, 2020

membphis commented Feb 8, 2020 •

edited

Loading

membphis commented Feb 9, 2020

Modify bin/apisix to support the SO_REUSEPORT #1085

Modify bin/apisix to support the SO_REUSEPORT #1085

Conversation

Miss-you commented Jan 19, 2020

Summary

Full changelog

Issues resolved

Choose a reason for hiding this comment

moonming left a comment

Choose a reason for hiding this comment

Miss-you commented Jan 22, 2020 • edited Loading

membphis commented Jan 22, 2020

spacewander commented Jan 24, 2020

Miss-you commented Feb 3, 2020

Miss-you commented Feb 3, 2020

membphis commented Feb 3, 2020

Miss-you commented Feb 5, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

membphis commented Feb 6, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

membphis commented Feb 8, 2020 • edited Loading

membphis commented Feb 9, 2020

Miss-you commented Jan 22, 2020 •

edited

Loading

membphis commented Feb 8, 2020 •

edited

Loading