bugfix: missing clear table before to reuse table.
#1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this PR depends on #1129 |
moonming
reviewed
Feb 18, 2020
|
need to add more infomation about this bug: memory leak? |
membphis
commented
Feb 18, 2020
| idx = 0 | ||
|
|
||
| if code and type(code) ~= "number" then | ||
| insert_tab(t, code) |
There was a problem hiding this comment.
Always insert new data and then memory leak.
please take a look at: https://github.com/apache/incubator-apisix/pull/1134/files#r380657179 |
moonming
approved these changes
Feb 18, 2020
qiujiayu
pushed a commit
to qiujiayu/incubator-apisix
that referenced
this pull request
Feb 20, 2020
* test: avoid to use regex for matching output.
qiujiayu
pushed a commit
to qiujiayu/incubator-apisix
that referenced
this pull request
Feb 21, 2020
* test: avoid to use regex for matching output.
SaberMaster
pushed a commit
to SaberMaster/incubator-apisix
that referenced
this pull request
Jun 30, 2020
* test: avoid to use regex for matching output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.