Add multiple etcd support. #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @membphis An issue in travis again
Any idea ? |
I have restarted the Travis job. It seems fine |
membphis
reviewed
Mar 16, 2020
|
@membphis am so sorry for the PR rebase problem but the rebase was not done correctly for the first time it created a little mess there so I closed that PR. |
membphis
requested changes
Mar 17, 2020
Akayeshmantha
force-pushed
the
patch11
branch
2 times, most recently
from
3e1726a
to
b536aa7
Compare
membphis
reviewed
Mar 17, 2020
membphis
reviewed
Mar 18, 2020
|
@membphis done |
membphis
approved these changes
Mar 18, 2020
membphis
requested changes
Mar 18, 2020
membphis
reviewed
Mar 18, 2020
membphis
reviewed
Mar 18, 2020
membphis
approved these changes
Mar 18, 2020
There was a problem hiding this comment.
We can merge it after running the test case. nice job @Akayeshmantha
|
thanks @membphis . It was a great learning experience |
|
@membphis any documents to be updated ? |
I think you can add comments and a example in config.yaml |
membphis
approved these changes
Mar 19, 2020
|
@Akayeshmantha merged, many thx |
SaberMaster
pushed a commit
to SaberMaster/incubator-apisix
that referenced
this pull request
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add multiple etcd address support
Issues resolved
Fix #1231