support to run header_filter and body_filter phase for global rules.
#1364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacewander
requested changes
Mar 30, 2020
|
@Akayeshmantha |
|
Sure @spacewander created a new issue #1369 since this ticket mentioned a different issue |
spacewander
requested changes
Mar 30, 2020
|
@membphis can we merge this if its ok? |
membphis
requested changes
Mar 31, 2020
|
@membphis done changes |
membphis
approved these changes
Mar 31, 2020
|
@Akayeshmantha you need to rebase you PR after c76e7e3 merged |
|
@membphis rebased |
|
@spacewander please take a look |
spacewander
approved these changes
Apr 1, 2020
membphis
approved these changes
Apr 2, 2020
SaberMaster
pushed a commit
to SaberMaster/incubator-apisix
that referenced
this pull request
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues resolved
Fix #1338