Add sys logger.

[Akayeshmantha]

Issues resolved

Fix #1406

[Akayeshmantha]

@membphis @moonming

I think something wrong in trvis

Error: Failed installing dependency: https://luarocks.org/lua-resty-cookie-0.1.0-1.rockspec - Error fetching file: Failed downloading https://luarocks.org - Failed downloading https://luarocks.org/lua-resty-cookie-0.1.0-1.rockspec - /Users/travis/.cache/luarocks/https___luarocks.org/lua-resty-cookie-0.1.0-1.rockspec
make: *** [deps] Error 1
The command "$PWD/.travis/${OSNAME}_runner.sh do_install" failed and exited with 2 during .
Your build has been stopped.

But the module is available. Can we restart travis ?

[moonming]

I restart travis CI

[Akayeshmantha]

@membphis @moonming

It's ready to revew.

[membphis]

By the way, the current implementation mechanism of resty-logger is not very suitable for APISIX.

In APISIX, we can create multiple routes and set different plug-in configurations, such as using different host and port for the plugin syslog.

The initialization of resty-logger is global, and it is impossible to use different resty-logger objects for different plugin configurations.

[Akayeshmantha]

Yes you are right .so means we have to check another library than resty logger? @membphis
Since its limited for one host I think we have to do so

[membphis]

so means we have to check another library than resty logger?

We can try to find other solutions, if there is no suitable, we need to modify the resty-logger.

[Akayeshmantha]

Yeah I think it will be ok if we have a new socket connection open like below ? @membphis

    location /m {
        log_by_lua '
            local logger_socket = require "resty.logger.socket"
            local logger = logger_socket:new()
            if not logger:initted() then
                local ok, err = logger:init{
                    host = 'xxx',
                    port = 1234,
                    flush_limit = 1234,
                    drop_limit = 5678,
                }
                if not ok then
                    ngx.log(ngx.ERR, "failed to initialize the logger: ",
                            err)
                    return
                end
            end

            local bytes, err = logger:log(msg)
            if err then
                ngx.log(ngx.ERR, "failed to log message: ", err)
                return
            end
        ';
    }`

`

[membphis]

We need a way to create or destroy logger objects, which requires complete lifecycle management.

only create is not enough.

[Akayeshmantha]

1. cloudflare/lua-resty-logger-socket@master...whuben:master
2. bsc-s2/lua-resty-logger-socket@d5c2bf2

from these 2 what is the one we are going to pick when moving forward
@membphis @moonming

[membphis]

The two implementation methods are similar, but the second one has test cases, so I prefer it.

bsc-s2/lua-resty-logger-socket@d5c2bf2

[Akayeshmantha]

Sure @membphis

[Akayeshmantha]

@membphis updated with the latest library

[Akayeshmantha]

@membphis changed to use api.ctx. Also rebased with the master.

[Akayeshmantha]

@membphis resolve the conflicts

[Akayeshmantha]

@membphis can we merge this 🙂

[Akayeshmantha]

Hi guys @moonming @membphis can we merge this so I can work on this issue and finish things on sys logger.
#1500

[moonming]

Hi guys @moonming @membphis can we merge this so I can work on this issue and finish things on sys logger.
#1500

lgtm