Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if we can switch serialization/deser between IO and Dubbo Threads. #2131

Closed
chickenlj opened this issue Jul 25, 2018 · 8 comments
Closed
Milestone

Comments

@chickenlj
Copy link
Contributor

chickenlj commented Jul 25, 2018

Here's the doc describing Dubbo's ThreadPool Model: http://dubbo.apache.org/#!/docs/user/demos/thread-model.md?lang=zh-cn

Here's the code deciding Serialization thread
https://github.com/apache/incubator-dubbo/blob/70e1e6220b82fd20611d7ec2624726442671bf95/dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/DubboCodec.java#L88

@chickenlj chickenlj added this to the 2.6.4 milestone Jul 25, 2018
@tswstarplanet
Copy link
Contributor

tswstarplanet commented Aug 2, 2018

Excuse me. What is the meaning of "switch serialization/deser between IO and Dubbo Threads"?

@zonghaishang
Copy link
Member

Netty io thread & dubbo thread pool

@tswstarplanet
Copy link
Contributor

tswstarplanet commented Aug 2, 2018

@zonghaishang So it just means that we should check if the serialization/deser will succeed ?

@zonghaishang
Copy link
Member

You are right, but more likely to provide a parameter configuration, the internal decision of the framework

@tswstarplanet
Copy link
Contributor

But how do we know if the serialization/deser will succeed?

@ranchoswang
Copy link

ranchoswang commented Aug 7, 2018

In default , decode in io is open , You can use
<ddubbo:protocol decode.in.io="false"> in xml to close it (when you think deser takes long enough time).

@sinmaystar
Copy link

we can switch serialization thread like this:
<dubbo:protocol name="dubbo" port="20880">
<dubbo:parameter key="decode.in.io" value="false"/>
</dubbo:protocol>

there is no need to modify source code or add user define xml schema

@diecui1202
Copy link

@chickenlj IMO, there is nothing we can do from the comments, I'll close it. Any thoughts ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants