-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async enhancement #3184
Async enhancement #3184
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.7.0-release #3184 +/- ##
==================================================
- Coverage 63.83% 63.8% -0.03%
Complexity 75 75
==================================================
Files 651 651
Lines 28317 28311 -6
Branches 4793 4792 -1
==================================================
- Hits 18076 18064 -12
- Misses 7973 7975 +2
- Partials 2268 2272 +4
Continue to review full report at Codecov.
|
dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/AsyncContextImpl.java
Show resolved
Hide resolved
dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/AsyncContextImpl.java
Outdated
Show resolved
Hide resolved
dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/RpcContext.java
Show resolved
Hide resolved
dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/proxy/AbstractProxyInvoker.java
Show resolved
Hide resolved
one more thing, should we override setAsync(boolean) on ProviderConfig to warn user this only works on client side? |
I will check if |
LGTM |
why stop tag from being transferred in the RPC chain? |
What is the purpose of the change
async=true
on Provider side to use provider async feature anymore, onlyAsyncContext.startAsync()
is necessary.Brief changelog
Verifying this change
run
samples-async
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.