Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async enhancement #3184

Merged
merged 6 commits into from
Jan 11, 2019
Merged

Conversation

chickenlj
Copy link
Contributor

What is the purpose of the change

  • User does not have to set async=true on Provider side to use provider async feature anymore, only AsyncContext.startAsync() is necessary.
  • stop tag from being transferred in the RPC chain

Brief changelog

  • AsyncContext related classes
  • ContextFilter

Verifying this change

run samples-async

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

codecov-io commented Jan 10, 2019

Codecov Report

Merging #3184 into 2.7.0-release will decrease coverage by 0.02%.
The diff coverage is 70%.

Impacted file tree graph

@@                Coverage Diff                 @@
##             2.7.0-release   #3184      +/-   ##
==================================================
- Coverage            63.83%   63.8%   -0.03%     
  Complexity              75      75              
==================================================
  Files                  651     651              
  Lines                28317   28311       -6     
  Branches              4793    4792       -1     
==================================================
- Hits                 18076   18064      -12     
- Misses                7973    7975       +2     
- Partials              2268    2272       +4
Impacted Files Coverage Δ Complexity Δ
...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java 66.1% <ø> (-0.57%) 0 <0> (ø)
...g/apache/dubbo/rpc/proxy/AbstractProxyInvoker.java 50% <0%> (ø) 0 <0> (ø) ⬇️
...ava/org/apache/dubbo/rpc/filter/ContextFilter.java 93.1% <100%> (+0.51%) 0 <0> (ø) ⬇️
...in/java/org/apache/dubbo/rpc/AsyncContextImpl.java 58.33% <50%> (+4.48%) 0 <0> (ø) ⬇️
...src/main/java/org/apache/dubbo/rpc/RpcContext.java 71.02% <75%> (+0.23%) 0 <0> (ø) ⬇️
...bbo/registry/support/ProviderConsumerRegTable.java 80.48% <0%> (-4.88%) 0% <0%> (ø)
...onfig/spring/extension/SpringExtensionFactory.java 80.48% <0%> (-4.88%) 0% <0%> (ø)
...e/dubbo/remoting/transport/netty/NettyChannel.java 57.64% <0%> (-4.71%) 0% <0%> (ø)
...he/dubbo/remoting/transport/netty/NettyServer.java 67.85% <0%> (-3.58%) 0% <0%> (ø)
...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java 72.5% <0%> (-1.67%) 0% <0%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 747b804...42f537f. Read the comment docs.

@beiwei30
Copy link
Member

one more thing, should we override setAsync(boolean) on ProviderConfig to warn user this only works on client side?

@chickenlj
Copy link
Contributor Author

one more thing, should we override setAsync(boolean) on ProviderConfig to warn user this only works on client side?

I will check if setAsync(boolean) is newly added in 2.7.0 or not. If it is newly added, I think we should remove or override it.

@beiwei30 beiwei30 merged commit 347f154 into apache:2.7.0-release Jan 11, 2019
@beiwei30
Copy link
Member

LGTM

@zhangyl
Copy link

zhangyl commented Nov 10, 2020

why stop tag from being transferred in the RPC chain?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants