-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dubbo-3169]Check future status before get(), return default value if not completed yet. #3185
Conversation
Check future status before get().
Codecov Report
@@ Coverage Diff @@
## 2.7.0-release #3185 +/- ##
===================================================
- Coverage 63.83% 63.78% -0.05%
Complexity 75 75
===================================================
Files 651 651
Lines 28317 28317
Branches 4793 4793
===================================================
- Hits 18076 18063 -13
- Misses 7973 7982 +9
- Partials 2268 2272 +4
Continue to review full report at Codecov.
|
dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/AsyncRpcResult.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chickenlj
Other than one minor comment which I have given, it looks fine to me.
@chickenlj
In this scenario, |
What is the purpose of the change
Brief changelog
Verifying this change
run
dubbo-samples-async
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.