Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize apollo extension #3263

Merged

Conversation

chickenlj
Copy link
Contributor

@chickenlj chickenlj commented Jan 17, 2019

What is the purpose of the change

optimize the Apollo extension of Config-Center SPI

Brief changelog

ApolloDynamicConfiguration

Verifying this change

https://github.com/apache/incubator-dubbo-samples/tree/samples-for-2.7.0-SNAPSHOT/dubbo-samples-configcenter/dubbo-samples-configcenter-apollo

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@chickenlj chickenlj requested a review from cvictory January 17, 2019 06:50
@chickenlj chickenlj added this to the 2.7.0 milestone Jan 17, 2019
@codecov-io
Copy link

codecov-io commented Jan 17, 2019

Codecov Report

Merging #3263 into 2.7.0-release will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             2.7.0-release    #3263      +/-   ##
===================================================
- Coverage            63.65%   63.62%   -0.03%     
  Complexity              75       75              
===================================================
  Files                  658      658              
  Lines                28538    28545       +7     
  Branches              4825     4825              
===================================================
- Hits                 18166    18163       -3     
- Misses                8095     8106      +11     
+ Partials              2277     2276       -1
Impacted Files Coverage Δ Complexity Δ
...ter/support/apollo/ApolloDynamicConfiguration.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../remoting/transport/netty4/NettyClientHandler.java 75% <0%> (-11.12%) 0% <0%> (ø)
...che/dubbo/remoting/transport/mina/MinaChannel.java 43.42% <0%> (-10.53%) 0% <0%> (ø)
...onfig/spring/extension/SpringExtensionFactory.java 78.04% <0%> (-7.32%) 0% <0%> (ø)
.../dubbo/remoting/transport/netty4/NettyChannel.java 61.17% <0%> (-4.71%) 0% <0%> (ø)
...e/dubbo/remoting/transport/netty/NettyChannel.java 54.11% <0%> (-3.53%) 0% <0%> (ø)
.../exchange/support/header/HeaderExchangeServer.java 58.11% <0%> (-1.71%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0%> (ø) 0% <0%> (ø) ⬇️
.../java/org/apache/dubbo/config/ReferenceConfig.java 58.08% <0%> (+0.36%) 0% <0%> (ø) ⬇️
...he/dubbo/registry/multicast/MulticastRegistry.java 65.08% <0%> (+1.29%) 0% <0%> (ø) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c79f09c...6c3fcc1. Read the comment docs.

Copy link
Contributor

@cvictory cvictory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have review the code and run the sample.

@cvictory cvictory merged commit 87a1bd7 into apache:2.7.0-release Jan 17, 2019
@chickenlj chickenlj deleted the configcenter-apollo-optimization branch September 3, 2019 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants