Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x dev rx support #3609

Merged
merged 4 commits into from
Mar 7, 2019
Merged

3.x dev rx support #3609

merged 4 commits into from
Mar 7, 2019

Conversation

uglycow
Copy link
Contributor

@uglycow uglycow commented Mar 7, 2019

What is the purpose of the change

support using Flux and Mono as return value

#3608

Brief changelog

all code is in the module called dubbo-rpc-rsocket.

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@uglycow
Copy link
Contributor Author

uglycow commented Mar 7, 2019

we now support using Mono/Flux as return value. but we can't using Mono/Flux as args yet. i would try to support that with another pr.

@codecov-io
Copy link

Codecov Report

Merging #3609 into 3.x-dev will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             3.x-dev    #3609      +/-   ##
=============================================
- Coverage      63.84%   63.83%   -0.02%     
  Complexity        75       75              
=============================================
  Files            656      656              
  Lines          28449    28449              
  Branches        4812     4812              
=============================================
- Hits           18164    18160       -4     
  Misses          8005     8005              
- Partials        2280     2284       +4
Impacted Files Coverage Δ Complexity Δ
...ache/dubbo/remoting/p2p/support/AbstractGroup.java 45.45% <0%> (-11.37%) 0% <0%> (ø)
.../remoting/transport/netty4/NettyClientHandler.java 75% <0%> (-11.12%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0%> (-4.35%) 0% <0%> (ø)
...he/dubbo/remoting/transport/netty/NettyServer.java 67.85% <0%> (-3.58%) 0% <0%> (ø)
...c/main/java/org/apache/dubbo/rpc/RpcException.java 82.75% <0%> (-3.45%) 0% <0%> (ø)
...org/apache/dubbo/rpc/protocol/AbstractInvoker.java 62.9% <0%> (-3.23%) 0% <0%> (ø)
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 87.85% <0%> (-1.87%) 0% <0%> (ø)
...dubbo/remoting/exchange/support/DefaultFuture.java 73.15% <0%> (ø) 0% <0%> (ø) ⬇️
.../java/org/apache/dubbo/config/ReferenceConfig.java 60% <0%> (+0.71%) 0% <0%> (ø) ⬇️
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0%> (+7.54%) 0% <0%> (ø) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bef8f6d...fbd6700. Read the comment docs.

@chickenlj
Copy link
Contributor

LGTM.

@chickenlj chickenlj merged commit 020697b into apache:3.x-dev Mar 7, 2019
@chickenlj chickenlj added this to the 3.0 milestone Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants