fix bug #9704 #10129
Closed
fix bug #9704 #10129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 26, 2019 17:03
100pah
requested changes
Mar 19, 2019
| @@ -46,7 +46,7 @@ export default { | |||
| var lineType = this.get('type'); | |||
| var dotSize = Math.max(lineWidth, 2); | |||
| var dashSize = lineWidth * 4; | |||
| return (lineType === 'solid' || lineType == null) ? null | |||
There was a problem hiding this comment.
According to https://github.com/ecomfe/zrender/blob/master/src/graphic/Path.js#L136
I think default value should better not be a [0, 0], but still null is better.
For this issue, probably we can always set a value to style.lineDash in method getLineStyle above whether line dash is null or not.
There was a problem hiding this comment.
I understand! I just choose the simplest way, but don't know whether this way is the best!
100pah
added a commit
that referenced
this pull request
Apr 21, 2019
This was referenced Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.