Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #10248 #10250

Merged
merged 3 commits into from
Jun 18, 2019
Merged

fix #10248 #10250

merged 3 commits into from
Jun 18, 2019

Conversation

quick-sort
Copy link

@quick-sort quick-sort commented Apr 10, 2019 •
edited by Ovilia
Loading

Ovilia
Ovilia requested changes Apr 10, 2019
View reviewed changes
src/model/mixin/dataFormat.js Outdated Show resolved Hide resolved
src/model/mixin/dataFormat.js Outdated Show resolved Hide resolved
src/model/mixin/dataFormat.js Outdated Show resolved Hide resolved
src/model/mixin/dataFormat.js Outdated Show resolved Hide resolved
@quick-sort
Copy link
Author

changes resolved

@quick-sort quick-sort closed this Apr 10, 2019
@quick-sort quick-sort reopened this Apr 10, 2019
@100pah
Copy link
Member

100pah commented Jun 17, 2019

Thanks @quick-sort .

The defaultedLabel is by "guess". So I think we should not restrict that only give the values of the defaultedLabel to users, but give all of the possible values.
But yes, in the param we'd better provide the mapping info (x -> which dimension, y -> which dimension) to users, by which the corresponding values can be fetched in each series.

@100pah 100pah merged commit 0f6b137 into apache:master Jun 18, 2019
100pah added a commit that referenced this pull request Jun 18, 2019
@100pah
Add dimensionNames and encode info to formatter callback params.
c07b8ca 
Fix #10248  Close #10250
@100pah 100pah mentioned this pull request Jun 18, 2019
Merged
100pah added a commit that referenced this pull request Jun 18, 2019
@100pah
Add dimensionNames and encode info to formatter callback params.
aa18fa0 
Fix #10248  Close #10250
@snyk-bot snyk-bot mentioned this pull request Dec 5, 2019
Open
This was referenced Mar 24, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ovilia Ovilia Ovilia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@quick-sort @100pah @Ovilia @hilr