-
Notifications
You must be signed in to change notification settings - Fork 19.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 11236 integrate stack/tile button into one toggle button in toolbox #11367
Conversation
Awesome! I think this can be scheduled in this version 4.5.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested and ran locally. The text changed and seems to be working as expected. But the icon didn't change. Is this expected? @alex2wong
@Ovilia Yes, as the function specs mentioned.. Icon itself did not switch between stack/tiled, only the title and emphasis status changed. Of course, here's another design, switch between stack/tiled icon instead of emphasis it. How do you think about it ? |
@alex2wong Hi, I did some improvements based on yours in the PR #11743 |
thank you, @pissang. It looks much better~ |
related issue #11236
new design integrate stack/tile button into one toggle button in toolbox, function spec as follows: