Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gauge): update data with dataset #10945 #11373

Merged
merged 5 commits into from
Oct 21, 2019
Merged

fix(gauge): update data with dataset #10945 #11373

merged 5 commits into from
Oct 21, 2019

Conversation

Ovilia
Copy link
Contributor

@Ovilia Ovilia commented Oct 8, 2019

There was a bug when calling setOption with changing dataset.source #10945.

After fixing, the data can be updated and if there are multiple data, the pointers would be multiple, and the label would be about the first data.

In the visual test gauge-simple.html, the previous bug can be reproduced with v4.3.0 (left), and the result after fixing is shown in the center.

image

because this was not supported since 4.0
100pah
100pah previously approved these changes Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants