fix(time): bar bandWidth with time axis #11145 #11479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pissang
reviewed
Oct 25, 2019
pissang
reviewed
Oct 28, 2019
src/layout/barGrid.js
Outdated
| // Ignore 0 delta because they are of the same axis value | ||
| var delta = axisValues[i][j] - axisValues[i][j - 1]; | ||
| delta = delta === 0 ? Number.MAX_VALUE : delta; | ||
| min = Math.min(min, delta); |
There was a problem hiding this comment.
I suggested changing these two lines to
if (delta > 0) {
min = Math.min(min, delta)
}to make it more clear and effecient.
pissang
approved these changes
Oct 28, 2019
|
LGTM now |
100pah
reviewed
Oct 28, 2019
Ovilia
added a commit
that referenced
this pull request
Oct 29, 2019
Ovilia
added a commit
that referenced
this pull request
Oct 29, 2019
This was referenced Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(time): bar bandWidth with time axis #11145
before fixing (see bar2.html):
after fixing:
Bandwidth is calculated using the min gap between two adjacent time values of all series.
There's a bug with data filtering as reported in #11478, which is not raised in this pull request and can be reproduced with v4.4.0.