Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: quantityExponent #11249 #11488

Merged
merged 2 commits into from
Oct 25, 2019
Merged

fix: quantityExponent #11249 #11488

merged 2 commits into from
Oct 25, 2019

Conversation

Ovilia
Copy link
Contributor

@Ovilia Ovilia commented Oct 25, 2019

fix: quantityExponent #11249

Before the fix, two cases fail in the unit test:

expect(numberUtil.quantityExponent(1000)).toEqual(3);
expect(numberUtil.quantity(1000)).toEqual(1000);

After the fix, the test cases pass.

@Ovilia Ovilia merged commit d5c2522 into master Oct 25, 2019
@Ovilia Ovilia deleted the fix-11249 branch October 25, 2019 06:47
@snyk-bot snyk-bot mentioned this pull request Dec 5, 2019
Open
This was referenced Mar 24, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pissang pissang pissang approved these changes

Assignees
No one assigned
Labels
PR: author is committer PR: awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ovilia @pissang