fix(bar): fix bar width calculation with barMaxWidth constraint and barGap -100% #7356 #11713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7356
The cause of this bug is in the line https://github.com/apache/incubator-echarts/blob/fix-bar-width-100/src/layout/barGrid.js#L292
The
widthwill be constraint by theremainedWidth, which is the space can still be used for the remaining series. It is calcuated in https://github.com/apache/incubator-echarts/blob/fix-bar-width-100/src/layout/barGrid.js#L321 In the original buggy code, the barGap is not considered. So the calculated remaining width is much smaller than it should be when the barGap is set-100%.