fix: fix candlestick throw error when some series filtered by legend. #12027
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
fix candlestick throw error when some series filtered by legend.
Fixed issues
fix #11611
Details
Before: What was the problem?
Throw error. see the case in #11611 .
After: How is it fixed in this PR?
Fix it by null checking.
But it might not be a best way.
If intending to declare
performRawSeries
in handlers, onlystream-independent (specifically, data item independent) operations can be
performed. Because is a series is filtered, most of the tasks will not
be performed. A stream-dependent operation probably cause wrong biz logic.
Perhaps we should not provide a separate callback for this case instead
of providing the config
performRawSeries
. The stream-dependent operationsand stream-independent operations should better not be mixed.
It can be down in future version because some more tests and check are needed,
now that the deadline of 4.7.0 is coming.
Related test cases or examples to use the new APIs
test/stream-filter2.html
.Others
Merging options
Other information