fix(tooltip): keep axis tooltip open on refresh

[dr-itz]

Brief Information

This pull request is in the type of:

• bug fixing

What does this PR do?

Fix a tooltip disappearing when tooltip trigger is "axis" and data is refreshed.

Fixed issues

Details

Before: What was the problem?

Chart with datazoom slider and live update every few seconds. The slider is somewhere in the middle with a fixed value range. When the user hovers over the data, the tooltip with trigger "axis" shows correctly. But as soon as new data is pushed to the chart the tooltip disappears. This PR fixes that.

After: How is it fixed in this PR?

Tooltip with trigger axis stays when data is refresehd.

Usage

Are there any API changes?

• The API has been changed.

Related test cases or examples to use the new APIs

NA.

Others

Merging options

• Please squash the commits into a single one when merge.

Other information

[susiwen8]

@dr-itz Thanks, but could you make a PR to next branch?

[dr-itz]

@dr-itz Thanks, but could you make a PR to next branch?

sure, will do. Out of curiosity, will there be another 4.x.y release?

[susiwen8]

@dr-itz 4.9 is the last one which will be released in few days.

[dr-itz]

@dr-itz 4.9 is the last one which will be released in few days.

thanks for letting me know. I'd really appreciate this PR here to be part of 4.9 since it's something we no proper workaround for.

Of course I'll do the fix for next as well

[susiwen8]

I'm afraid that's too late, 4.9 has been voted through, so we cannot add any feature or fix in this release @dr-itz

[susiwen8]

If this feature were really urgent to you, I suggest to build ECharts by yourself. @dr-itz
@Ovilia @100pah @pissang Should we add this PR in 5.0?

[dr-itz]

I only just realized that there is a _lastDataByCoordSys already, so this might be simpler than this.

Btw 😍 the move to TypeScript in next

[dr-itz]

I only just realized that there is a _lastDataByCoordSys already, so this might be simpler than this.

changed it to use that. It's simpler and works as expected. I also tested the non-axis trigger and couldn't find any problem. I'm not familiar enough with this to see why _lastDataByCoordSys was cleared in render(), so I'm not sure about that one. I think _tryShow() and manuallyHideTip() should clear it when necessary.

I'll rebase for next later 😉

[dr-itz]

sorry for the delay..I finally found some time and rebased this to next

[pissang]

LGTM. Clearing _lastDataByCoordSys seems to be a mistake. Thanks for the work! @dr-itz

[echarts-bot]

Congratulations! Your PR has been merged. Thanks for your contribution! 👍