chore(dts): generate bundled dts distribution #13563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! The pull request is marked to be |
100pah
previously approved these changes
Nov 8, 2020
100pah
approved these changes
Nov 8, 2020
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is about adding dts bundle in the npm distribution.
What does this PR do?
Generate a clean DTS bundle
It will generate a dts bundle
types/dist/echarts.d.tswith rollup-plugin-dts plugin. And the default type entry will be changed to this file. This bundle can also be used in https://github.com/apache/incubator-echarts-examples for type checkingThis change will simplify the types exposed to developers. To avoid inner module having errors when ts version is not compatible. Like issue #13541
To make sure no more inner module like
ComponentModel,ComponentView,Gridwill be exposed. This PR also made some changes to the type structure.Test generated DTS bundle
This PR includes a test case for testing the compatibility of different ts versions. It will test ts versions from
3.4to the latest( which is 4.0 at the moment this PR is created. Which means the lowest ts version our dts supported is3.4.Test command:
Fix some type issue in other ts versions