Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip dom append to body, use to top of layer #8049

Merged
merged 3 commits into from
Jan 9, 2020
Merged

Tooltip dom append to body, use to top of layer #8049

merged 3 commits into from
Jan 9, 2020

Conversation

xinpureZhu
Copy link
Contributor

#4627 解决 Tooltip 被其它图形遮挡的问题
1522255894822

@pissang
Copy link
Contributor

pissang commented Mar 29, 2018 •
edited
Loading

谢谢！这个 PR 中好像没有处理 tooltip 组件移除或者图表 dispose 后浮层的移除

@xinpureZhu
Copy link
Contributor Author

疏乎了，已补上提交

@balthazar
Copy link

你好! Any update on this?

@JoenZhu
Copy link

JoenZhu commented Nov 12, 2019

can anyone merge this pr?

dktjsp
dktjsp previously approved these changes Nov 15, 2019
View reviewed changes
@pissang pissang added this to the 4.7.0 milestone Nov 18, 2019
@pissang pissang requested a review from 100pah November 18, 2019 02:54
@100pah
Copy link
Member

100pah commented Jan 9, 2020 •
edited
Loading

This issue will be merged. Thanks to the great contribution of @xinpureZhu .

But a new option tooltip.appendToBody will be added to open this feature.
By default tooltip.appendToBody should be false, otherwise it is probably a big break change for some existing deep-customization usage.
And there would be more factors needed to be considered to ensure the "append to body" works correctly. Subsequent PR is under way.

@100pah 100pah merged commit 83ba469 into apache:master Jan 9, 2020
100pah added a commit that referenced this pull request Jan 12, 2020
@100pah
feature: support tooltip.appendToBody. Fix #8049. Based on the PR e…
44898bf 
…comfe/zrender#559 .
@100pah 100pah mentioned this pull request Jan 12, 2020
Merged
4 tasks
100pah added a commit that referenced this pull request Jan 13, 2020
@100pah
feature: support tooltip.appendToBody. Fix #8049. Based on the PR e…
c201b68 
…comfe/zrender#559 .
@snyk-bot snyk-bot mentioned this pull request Mar 25, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@100pah 100pah 100pah approved these changes

@dktjsp dktjsp dktjsp left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.
7 participants
@xinpureZhu @pissang @balthazar @JoenZhu @100pah @dktjsp @Ovilia