Pie chart adds filterValue parameter

[cuijian-dexter]

The value of the fan page of the pie chart is less than a certain value. The label and labelLine of this fan page are not displayed.

options={
  title: {
    text: '饼图标题',
    left: 16,
    textStyle: {
      fontSize: 14
    }
  },
  tooltip: {
    trigger: 'item',
    axisPointer: {
      //坐标轴指示器，坐标轴触发有效type: 'shadow'//默认为直线，可选为：'line'|'shadow'
    },
    extraCssText: 'max-width: 300px; word-break:break-all; white-space: normal'
  },
  legend: {
    data: [
      
    ]
  },
  series: [
    {
      type: 'pie',
      label: {
        normal: {
          show: true,
          limitScale: 0.02//小于2%的，不显示
        },
        emphasis: {
          show: true,
          textStyle: {
            fontSize: '14',
            fontWeight: 'bold'
          }
        }
      },
      labelLine: {
        lineStyle: {
          color: '#D9D9D9'
        }
      },
      data: [
        
      ]
    }
  ]
};

[100pah]

About the code:

(1) I think the option should not be on series.label, because both label and label line are controlled by the option. Probably it is better to be on series directly.

(2) Discussion:
I think the literal meaning of "limitScale" does not hint at what the feature does for users.
Any idea about the option name @Ovilia @pissang ?

(3) @cuijian-dexter the model should not be modified in the layout stage.
In fact, I think this feature should be implemented in the view rendering stage (PieView).

[cuijian-dexter]

@100pah
Thank you for reminding me. I know what you mean.
I will repair it tomorrow and commit it again.

[Ovilia]

Is this limitScale the value for filtering labels? How about filterValue?

[cuijian-dexter]

@100pah
According to your suggestion, I modified my code.
1.Add the option to series
2.LimitScale changed to filterValue
3.Modify in PieView.js

[100pah]

Sorry for the late reply.
Thanks @cuijian-dexter .

But I think that filterValue probably still does not cover this feature.
em... it is a percent value or angle value, and used to hide label but display segment as usual.
But filter indicates that totally all value and corresponding graphic elements removed.

May be, although not neat, cropLabel? labelCropThreshold? labelHideThreshold?
@Ovilia

[100pah]

// Should be
var xxxValue = seriesModel.get('xxxValue');

[Ovilia]

I'd better say labelDisplayThreshold. 😄

[cuijian-dexter]

@Ovilia filterValue changed to labelDisplayThreshold.😄

[Ovilia]

Let @100pah have a final review.

[cuijian-dexter]

@100pah hello,Can you make the final review？

[100pah]

does seriesModel.get('labelDisplayThreshold') returns an object?

[cuijian-dexter]

@100pah check it again.Thanks

var option = {
            title: {
                text: '饼图标题',
                left: 16,
                textStyle: {
                    fontSize: 14
                }
            },
            tooltip: {
                trigger: 'item',
                axisPointer: {
                },
                extraCssText: 'max-width: 300px; word-break:break-all; white-space: normal'
            },
            legend: {
                data: [
                        
                ]
            },
            series: [
                {
                    type: 'pie',
                    labelDisplayThreshold:0.1,//范围为0-1，默认为0，全部显示。百分比小于0.1的，不显示
                    label: {
                        normal: {
                            show: true
                        },
                        emphasis: {
                            show: true,
                            textStyle: {
                                fontSize: '14',
                                fontWeight: 'bold'
                            }
                        }
                    },
                    labelLine: {
                        lineStyle: {
                            color: '#D9D9D9'
                        }
                    },
                    data: [{
                        name:'1212',
                        value:100
                    },
                        {
                            name:'1212',
                            value:49.9
                        },
                        {
                            name:'1212',
                            value:100
                        },
                        {
                            name:'1212',
                            value:100
                        },
                        {
                            name:'1212',
                            value:100
                        },
                        {
                            name:'1212',
                            value:50.1
                        },

                    ]
                }
            ]
        }

[Ovilia]

If you add a new configure option, please also update document both in English and Chinese.
Make a PR for https://github.com/ecomfe/echarts-doc and link it here.

Thanks!

[cuijian-dexter]

@Ovilia ok,After the final review is completed,I will add again.
#8759 Has this been updated?

[Ovilia]

@cuijian-dexter Replied under #8759. :)

[Ovilia]

@100pah Please review this PR.

[100pah]

Sorry for my late reply.

[100pah]

By convention, a property name prefixed by a single '_' represents a "private member" of a class. We should not add other that kind of properties (_xxx) outside the class definition dynamically. Otherwise, it probably confuses the code reader and might overwrite the inner private members with the same name.

If we need to save the sum here, it's OK to save it to this, because in this module we have the legal control of this.

[cuijian-dexter]

ok,I can save sum to this.I change it

[cuijian-dexter]

@100pah Already bind _sum to this

[100pah]

@cuijian-dexter Sorry for my late reply.
I have merged this PR. But something related is needed to be refactored (including this feature and some old feature). I will try to do it soon.