Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[format] Unify name from target to destination #587

Closed
Thespica opened this issue Aug 12, 2024 · 2 comments · Fixed by #588
Closed

[format] Unify name from target to destination #587

Thespica opened this issue Aug 12, 2024 · 2 comments · Fixed by #588
Assignees
Labels
enhancement New feature or request

Comments

@Thespica
Copy link
Contributor

Describe the enhancement requested

There are naming conflict with single concept in proto:
AdjListType call it target
image
meanwhile EdgeInfo call it destination
image

We can unify them to destination.

Component(s)

Format

@Thespica Thespica added the enhancement New feature or request label Aug 12, 2024
@Thespica Thespica self-assigned this Aug 12, 2024
@SemyonSinchenko
Copy link
Member

@Thespica May we use dst and src instead of destination and source?

@Thespica
Copy link
Contributor Author

Thespica commented Aug 12, 2024

@Thespica May we use dst and src instead of destination and source?

I think it will be better to use full name, cause source and destination are more like specific concepts. We should unify usages of them.

(appended)emmmmm... it do bother to use full name everywhere, I consider we can use full name for enum or constant string, use src and dst in higher API?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants