Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Improve log message for connection errors #1654

Closed
congwang opened this issue Jan 3, 2017 · 4 comments · Fixed by #1678
Closed

Improve log message for connection errors #1654

congwang opened this issue Jan 3, 2017 · 4 comments · Fixed by #1678
Assignees
@congwang
Labels
enhancement stmgr
Milestone
0.14.6

Comments

@congwang
Copy link
Contributor

congwang commented Jan 3, 2017 •
edited by kramasamy
Loading

Logging a number is confusing:
W0103 20:25:17.030653 31955 stmgr-client.cpp:94] Could not connect to stmgr stmgr-147 running at <host>:<port> due to: 1
@objmagic
Copy link
Contributor

objmagic commented Jan 4, 2017

Not sure if important but please do not expose internal service hostname to the public

@kramasamy
Copy link
Contributor

yes - please remove the host name,

@kramasamy
Copy link
Contributor

thanks @objmagic for pointing it out. updated it.

@objmagic
Copy link
Contributor

got paged this morning and confused by these unclear log messages again...

@congwang congwang mentioned this issue Jan 24, 2017
Merged
@objmagic objmagic added this to the 0.14.6 milestone Jan 31, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@congwang congwang

Labels
enhancement stmgr
Projects
None yet
Milestone
0.14.6
Development

Successfully merging a pull request may close this issue.

Display error message for NetworkErrorCode apache/incubator-heron
3 participants
@kramasamy @congwang @objmagic