Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update serverless-workflow-foreach-quarkus example #1970

Open
LuboTerifaj opened this issue Jun 18, 2024 · 0 comments
Open

Update serverless-workflow-foreach-quarkus example #1970

LuboTerifaj opened this issue Jun 18, 2024 · 0 comments

Comments

@LuboTerifaj
Copy link

Description

Update serverless-workflow-foreach-quarkus example.

Issues

  • There is a wrong esxpected output from a request command in readme file:
    • curl -X POST -H 'Content-Type:application/json' -H 'Accept:application/json' -d '{"input": [1,2,3]}' http://localhost:8080/foreach
    • Readme file result:
      { 
        "workflowdata": {
              "output": [
                  2,
                  3,
                  4
              ]
          }
       }
      
    • Application result: {"id":"c9e6815d-9363-44fd-bd9f-29c7e0813cef","workflowdata":{"output":[4,6,8]}}
  • "Building and Deploying Workflow using CLI + Kogito Serverless Workflow Operator" section should be rewritten.
    • Wrong URLs in readme file:
      • "For this prepare your environment by following the instructions from here."
        • References the current readme file. It doesn't make sense to reference the same readme file here.
      • "Refer to Serverless Workflow Guide, to know how to build and deploy workflows using CLI + Kogito Serverless Workflow Operator.'
        • References the current readme file, which is most likely a mistake.
    • It would make sense to add at least some introduction why would somebody follow the instructions in this section.

Acceptance criteria

All issues listed above are resolved.

Implementation ideas

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant