Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-130]disable cpu/gpu consistency test for Proposal OP and Multi Proposal OP #10201

Merged
merged 2 commits into from
Mar 22, 2018
Merged

[MXNET-130]disable cpu/gpu consistency test for Proposal OP and Multi Proposal OP #10201

merged 2 commits into from
Mar 22, 2018

Conversation

wkcn
Copy link
Member

@wkcn wkcn commented Mar 22, 2018 •
edited
Loading

Description

I'm sorry that I made a mistake in the CPU/GPU consistency test for Proposal Operator and Multi Proposal Operator.

I disable cpu/gpu consistency test for Proposal OP and Multi Proposal OP temporarily until fixed.

Unit Test Detail:
http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/incubator-mxnet/detail/PR-10161/5/pipeline/549#step-919-log-1763

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@wkcn wkcn mentioned this pull request Mar 22, 2018
Merged
11 tasks
@marcoabreu
Copy link
Contributor

Please create a JIRA issue and link it in the test-disable-reason. The explanation you gave there gets put into the JIRA issue instead.

@wkcn wkcn changed the title disable cpu/gpu consistency test for Proposal OP and Multi Proposal OP [MXNET-130]disable cpu/gpu consistency test for Proposal OP and Multi Proposal OP Mar 22, 2018
@wkcn
Copy link
Member Author

wkcn commented Mar 22, 2018

@marcoabreu Hello. I have created a JIRA issue and linked it. Thank you!

marcoabreu
marcoabreu suggested changes Mar 22, 2018
View reviewed changes
tests/python/gpu/test_operator_gpu.py Outdated
@@ -1657,7 +1657,14 @@ def test_cross_device_autograd():

assert_almost_equal(dx, x.grad.asnumpy())

@unittest.skip('''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link the jira issue there and remove this description (it shows up in the test results)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it. Thank you!

@piiswrong piiswrong merged commit bcb4f9a into apache:master Mar 22, 2018
ashokei pushed a commit to ashokei/incubator-mxnet that referenced this pull request Mar 27, 2018
@wkcn @ashokei
[MXNET-130]disable cpu/gpu consistency test for Proposal OP and Multi…
3d10a22 
… Proposal OP (apache#10201)

* disable cpu/gpu consistency test for Proposal OP and Multi Proposal OP

* add jira issue link
jinhuang415 pushed a commit to jinhuang415/incubator-mxnet that referenced this pull request Mar 30, 2018
@wkcn
[MXNET-130]disable cpu/gpu consistency test for Proposal OP and Multi…
3323c36 
… Proposal OP (apache#10201)

* disable cpu/gpu consistency test for Proposal OP and Multi Proposal OP

* add jira issue link
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
@wkcn @piiswrong
[MXNET-130]disable cpu/gpu consistency test for Proposal OP and Multi…
9f83f0e 
… Proposal OP (apache#10201)

* disable cpu/gpu consistency test for Proposal OP and Multi Proposal OP

* add jira issue link
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
@wkcn @zheng-da
[MXNET-130]disable cpu/gpu consistency test for Proposal OP and Multi…
5404b16 
… Proposal OP (apache#10201)

* disable cpu/gpu consistency test for Proposal OP and Multi Proposal OP

* add jira issue link
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marcoabreu marcoabreu marcoabreu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wkcn @marcoabreu @piiswrong