Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: clarify logging source field #10306

Merged
merged 1 commit into from
Jul 14, 2020
Merged

chore: clarify logging source field #10306

merged 1 commit into from
Jul 14, 2020

Conversation

etr2460
Copy link
Member

@etr2460 etr2460 commented Jul 14, 2020

SUMMARY

Logging source: 'slice' here doesn't make a lot of sense, as you view slices both in explore and dashboard views. This should probably be explore instead

TEST PLAN

CI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

to: @graceguo-supercat

graceguo-supercat
graceguo-supercat approved these changes Jul 14, 2020
View reviewed changes
Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@etr2460 etr2460 merged commit f9c2600 into master Jul 14, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@auxten
chore: clarify logging source field (apache#10306)
1ce06a8
@amitmiran137 amitmiran137 deleted the erik-ritter--slice-to-explore branch March 29, 2021 18:09
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graceguo-supercat graceguo-supercat graceguo-supercat approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.38.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@etr2460 @graceguo-supercat @mistercrunch