-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: update webpack for npm linking plugins #11253
Conversation
superset-frontend/tsconfig.json
Outdated
// and the type defs of their dependencies | ||
"./node_modules/*superset-ui*/**/node_modules/**/*.d.ts" | ||
] | ||
], | ||
"exclude": ["./node_modules/*superset-ui*/**/node_modules/@superset-ui/**"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure whether this will help but it definitely looks more reasonable than current setup.
Codecov Report
@@ Coverage Diff @@
## master #11253 +/- ##
==========================================
- Coverage 65.59% 60.08% -5.51%
==========================================
Files 832 394 -438
Lines 39448 24757 -14691
Branches 3598 0 -3598
==========================================
- Hits 25874 14876 -10998
+ Misses 13465 9881 -3584
+ Partials 109 0 -109
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
SUMMARY
Update webpack config so that developers can
npm link .../plugin-path
without also having tonpm link ../path/to/superset-ui/packages/superset-ui-core/
. Currently you have to do the additional linking becausenpm link
will install its own version of@superset-ui/core
under the plugin'snode_modules
, which will take precedent for the plugin's JS modules during module resolution.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TEST PLAN
npm link ~/projects/superset-ui/plugins/legacy-preset-chart-nvd3/
insuperset-frontend
ADDITIONAL INFORMATION
cc @rusackas @villebro