Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed width for dataset panel #12221

Merged
merged 2 commits into from
Jan 6, 2021

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented Dec 29, 2020

SUMMARY

This PR sets a fixed width for dataset panel on Explore view - 320px. The goal was to prevent resizing when datasource changes and it's name is much shorter or longer than the previous one.
Closes #12142

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Nagranie.z.ekranu.2020-12-29.o.10.30.48.mov

TEST PLAN

ADDITIONAL INFORMATION

CC: @junlincc @etr2460

@kgabryje
Copy link
Member Author

@junlincc The issue doesn't specify the width, so I set it to 320px. I can change it of we want different value

Copy link
Member

@junlincc junlincc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this PR, both data and control panels are 320px, which look perfectly fine to me, while they are supposed to be 288px according to @mihir174 's the design proposal.
Because we are still at the intermediate stage where the control panel can not go down to 288px yet, it would look quite weird if two panels have different width. so let's keep both 320px for now.
Screen Shot 2021-01-01 at 1 36 55 PM

manually tested, LGTM

Screen.Recording.2021-01-01.at.1.31.50.PM.mov

Copy link
Member

@ktmud ktmud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ktmud ktmud closed this Jan 4, 2021
@ktmud ktmud reopened this Jan 4, 2021
@junlincc junlincc closed this Jan 5, 2021
@junlincc junlincc reopened this Jan 5, 2021
@codecov-io
Copy link

codecov-io commented Jan 5, 2021

Codecov Report

Merging #12221 (f2174a7) into master (f3ab1f4) will increase coverage by 0.69%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12221      +/-   ##
==========================================
+ Coverage   66.20%   66.89%   +0.69%     
==========================================
  Files         996     1002       +6     
  Lines       49174    49585     +411     
  Branches     4993     5090      +97     
==========================================
+ Hits        32554    33172     +618     
+ Misses      16476    16291     -185     
+ Partials      144      122      -22     
Flag Coverage Δ
cypress 51.42% <100.00%> (+7.32%) ⬆️
javascript 61.22% <0.00%> (+0.10%) ⬆️
python 64.14% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nd/src/explore/components/ExploreViewContainer.jsx 79.87% <100.00%> (+1.29%) ⬆️
...erset-frontend/src/SqlLab/components/ResultSet.tsx 44.54% <0.00%> (-22.28%) ⬇️
...ntend/src/explore/components/ExploreChartPanel.jsx 53.60% <0.00%> (-20.64%) ⬇️
superset-frontend/src/chart/Chart.jsx 53.08% <0.00%> (-20.13%) ⬇️
superset/commands/importers/v1/examples.py 34.11% <0.00%> (-11.34%) ⬇️
superset-frontend/src/components/Menu/Menu.tsx 83.17% <0.00%> (-10.80%) ⬇️
...explore/components/controls/AdhocFilterControl.jsx 55.44% <0.00%> (-10.21%) ⬇️
superset-frontend/src/components/Menu/NewMenu.tsx 80.00% <0.00%> (-4.62%) ⬇️
superset-frontend/src/components/Menu/SubMenu.tsx 97.61% <0.00%> (-2.39%) ⬇️
...perset-frontend/src/components/Menu/MenuObject.tsx 77.27% <0.00%> (-1.68%) ⬇️
... and 89 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3ab1f4...f2174a7. Read the comment docs.

@junlincc junlincc changed the title cosmetic: Fixed width for dataset panel fix: Fixed width for dataset panel Jan 5, 2021
@kgabryje kgabryje closed this Jan 5, 2021
@kgabryje kgabryje reopened this Jan 5, 2021
@junlincc junlincc closed this Jan 6, 2021
@junlincc junlincc reopened this Jan 6, 2021
@ktmud ktmud merged commit c8ad5c9 into apache:master Jan 6, 2021
@ktmud ktmud mentioned this pull request Jan 6, 2021
7 tasks
@junlincc junlincc added explore:datapanel Related to the Data panel of Explore Polidea and removed org:polidea labels Jan 8, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels explore:datapanel Related to the Data panel of Explore size/XS 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[explore] data panel should have fixed width
5 participants