-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fixed width for dataset panel #12221
Conversation
@junlincc The issue doesn't specify the width, so I set it to 320px. I can change it of we want different value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in this PR, both data and control panels are 320px, which look perfectly fine to me, while they are supposed to be 288px according to @mihir174 's the design proposal.
Because we are still at the intermediate stage where the control panel can not go down to 288px yet, it would look quite weird if two panels have different width. so let's keep both 320px for now.
manually tested, LGTM
Screen.Recording.2021-01-01.at.1.31.50.PM.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #12221 +/- ##
==========================================
+ Coverage 66.20% 66.89% +0.69%
==========================================
Files 996 1002 +6
Lines 49174 49585 +411
Branches 4993 5090 +97
==========================================
+ Hits 32554 33172 +618
+ Misses 16476 16291 -185
+ Partials 144 122 -22
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
SUMMARY
This PR sets a fixed width for dataset panel on Explore view - 320px. The goal was to prevent resizing when datasource changes and it's name is much shorter or longer than the previous one.
Closes #12142
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Nagranie.z.ekranu.2020-12-29.o.10.30.48.mov
TEST PLAN
ADDITIONAL INFORMATION
CC: @junlincc @etr2460