-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow 'refresh_immune_slices' #2974
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general except that the setting name is not specific enough, and you should add an entry in the docs/faq.rst
Also you can make sure you pass the build before sending in the PR by setting up travis-ci against your fork. It's really easy to setup and will run a build for each new push on your repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to 'timed_refresh_immune_slices' in latest commit, added usage to faq.rst
Any additional reviews on this PR? |
Ref #2958 , add a 'refresh_immune_slices' property to dashboards. Any slice ids listed will not be included in an automatic dashboard refresh.
I chose to exclude rather than include to be consist with filter_immune_slices.